Bug 849764 – sys-kernel/dracut lvm module missing grep

• Product: Gentoo Linux
• Status: RESOLVED FIXED

[Description Branko Grubic 2022-06-05 07:04:41 UTC]

With recent sys-kernel/dracut-056 I noticed on boot there is an error message that grep is missing for the lvm module:

dracut-initqueue[573]: /sbin/lvm_scan: line 55: grep: command not found
dracut-initqueue[576]: /sbin/lvm_scan: line 61: grep: command not found
dracut-initqueue[575]:   Configuration node devices/global_filter not found

For me it doesn't seem to cause any issues that I'm aware of, since all system disks are part of lvm and all boot and work fine.

After some investigation I found that lvm module doesn't install `grep` and it's already fixed upstream, but still unreleased.[1][2]

I'm not sure is it worth "backporting" including that commit, it's a simple fix, so I guess it's easy to include.



[1] https://github.com/dracutdevs/dracut/pull/1782
[2] https://github.com/dracutdevs/dracut/commit/79f9d9e1c29a9c8fc046ab20765e5bde2aaa3428

Reproducible: Always

[Comment 1 Branko Grubic 2022-06-05 07:37:02 UTC]

Created a pull request with bumped revision and patch added, I cloned upstream repo, did checkout to a specific commit, created a patch with `git format-patch HEAD~1`, tested locally, error is gone and system still boot fine.

One thing which I was not sure about is KEYWORDS how to control those.

[Comment 2 Larry the Git Cow 2022-06-07 23:47:14 UTC]

The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=99dfdcacc7c6b094d5e8d4c5c8ace4edbeb5a0f9

commit 99dfdcacc7c6b094d5e8d4c5c8ace4edbeb5a0f9
Author:     Branko Grubic <[e-mail]>
AuthorDate: 2022-06-05 07:19:52 +0000
Commit:     Sam James <[e-mail]>
CommitDate: 2022-06-07 23:46:59 +0000

    sys-kernel/dracut: Add missing grep to lvm module
    
    Includes upstream fix to add missing grep binary required
    by lvm module.
    
    https://github.com/dracutdevs/dracut/pull/1782/commits
    https://github.com/dracutdevs/dracut/commit/79f9d9e1c29a9c8fc046ab20765e5bde2aaa3428
    
    Closes: https://bugs.gentoo.org/849764
    Signed-off-by: Branko Grubic <[e-mail]>
    Closes: https://github.com/gentoo/gentoo/pull/25762
    Signed-off-by: Sam James <[e-mail]>

 sys-kernel/dracut/dracut-056-r1.ebuild             | 175 +++++++++++++++++++++
 .../056-fix-lvm-add-missing-grep-requirement.patch |  36 +++++
 2 files changed, 211 insertions(+)

[Comment 3 Sam James 2022-06-07 23:47:42 UTC]

(In reply to Branko Grubic from comment #1)
> Created a pull request with bumped revision and patch added, I cloned
> upstream repo, did checkout to a specific commit, created a patch with `git
> format-patch HEAD~1`, tested locally, error is gone and system still boot
> fine.
> 
> One thing which I was not sure about is KEYWORDS how to control those.

https://devmanual.gentoo.org/keywording/index.html#keywording-on-upgrades

so just ekeyword ~all ...

Thanks!