Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!

Bug 849227

Summary: x11-misc/x11vnc-0.9.16-r7 installs shell script that uses non-POSIX features
Product: Gentoo Linux Reporter: Agostino Sarubbo <ago>
Component: Current packagesAssignee: Alexander Tsoy <alexander>
Status: RESOLVED FIXED    
Severity: normal CC: gentoo, kfm, proxy-maint
Priority: Normal Keywords: PullRequest
Version: unspecified   
Hardware: All   
OS: Linux   
See Also: https://bugs.gentoo.org/show_bug.cgi?id=844178
https://github.com/gentoo/gentoo/pull/29949
Whiteboard:
Package list:
Runtime testing required: ---
Bug Depends on:    
Bug Blocks: 609070    
Attachments: build.log

Description Agostino Sarubbo gentoo-dev 2022-06-02 05:54:28 UTC
https://blogs.gentoo.org/ago/2020/07/04/gentoo-tinderbox/

Issue: x11-misc/x11vnc-0.9.16-r7 installs shell script that uses non-POSIX features.
Discovered on: amd64 (internal ref: ci)
Comment 1 Agostino Sarubbo gentoo-dev 2022-06-02 05:54:30 UTC
Created attachment 782174 [details]
build.log

build log and emerge --info
Comment 2 kfm 2023-03-09 23:07:24 UTC
As explained by https://bugs.gentoo.org/844178#c2, type isn't really a "non-POSIX" feature. Indeed, all of the current app-alternatives/sh providers support it. Regardless, my reason for posting is that the linked pull request isn't currently fit for inclusion because it misspells "command" as "cammand".
Comment 3 Alexander Tsoy 2023-03-10 01:47:33 UTC
(In reply to Kerin Millar from comment #2)
> Regardless, my reason for posting is that the linked
> pull request isn't currently fit for inclusion because it misspells
> "command" as "cammand".
Thanks. Fixed that.
Comment 4 Larry the Git Cow gentoo-dev 2023-03-11 17:15:36 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=b76f091b2cd8248248a55d9e8af6c3ea829e41ee

commit b76f091b2cd8248248a55d9e8af6c3ea829e41ee
Author:     Alexander Tsoy <alexander@tsoy.me>
AuthorDate: 2023-03-05 22:26:23 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2023-03-11 17:15:12 +0000

    x11-misc/x11vnc: fix implicit function declarations in configure
    
    Also fix issue reported by checkbashisms and remove trailing spaces from
    init script.
    
    Closes: https://bugs.gentoo.org/849227
    Closes: https://bugs.gentoo.org/898398
    Signed-off-by: Alexander Tsoy <alexander@tsoy.me>
    Signed-off-by: Sam James <sam@gentoo.org>

 ...1vnc-0.9.16-implicit-function-declaration.patch | 26 ++++++++++++++++++++++
 x11-misc/x11vnc/files/x11vnc.init.d-r1             |  8 +++----
 x11-misc/x11vnc/x11vnc-0.9.16-r7.ebuild            |  5 +++--
 3 files changed, 33 insertions(+), 6 deletions(-)