Bug 848906

Summary:	app-vim/gitgutter-20220524 fetches file(s) that do not match recorded size
Product:	Gentoo Linux	Reporter:	Agostino Sarubbo <ago>
Component:	Current packages	Assignee:	Vim Maintainers <vim>
Status:	RESOLVED FIXED
Severity:	normal	CC:	sam, t
Priority:	Normal	Keywords:	PullRequest
Version:	unspecified
Hardware:	All
OS:	Linux
See Also:	https://github.com/gentoo/gentoo/pull/25720
Whiteboard:
Package list:		Runtime testing required:	---
Attachments:	build.log

Description Agostino Sarubbo gentoo-dev

2022-06-01 06:15:50 UTC

https://blogs.gentoo.org/ago/2020/07/04/gentoo-tinderbox/

Issue: app-vim/gitgutter-20220524 fetches file(s) that do not match recorded size.
Discovered on: amd64 (internal ref: ci)

NOTE:
While the resolution of this bug may be trivial I'd like to suggest to pay attention at WHY and if it is the case of a tarball fraudulently replaced (hacked mirror).

Comment 1 Agostino Sarubbo gentoo-dev

2022-06-01 06:15:52 UTC

CC'ing also the author of the commit (8c659f037944be911121b4c4e43ff06aa3316ecf)

Comment 2 Agostino Sarubbo gentoo-dev

2022-06-01 06:15:53 UTC

Created attachment 781775 [details]
build.log

build log and emerge --info

Comment 3 Agostino Sarubbo gentoo-dev

2022-06-01 06:15:54 UTC

Error(s) that match a know pattern:


 * Fetch failed for 'app-vim/gitgutter-20220524', Log file:
!!! Reason: Filesize does not match recorded size

Comment 4 Thomas Bracht Laumann Jespersen 2022-06-01 07:44:13 UTC

Interesting. Reproducing I get the same result, as in the provided build.log

2022-06-01 09:40:04 (6.50 MB/s) - ‘/var/cache/distfiles/gitgutter-20220524.tar.gz.__download__’ saved [602709]

!!! Fetched file: gitgutter-20220524.tar.gz VERIFY FAILED!
!!! Reason: Filesize does not match recorded size
!!! Got:      602709
!!! Expected: 46741
Refetching... File renamed to '/var/cache/distfiles/gitgutter-20220524.tar.gz._checksum_failure_.l5uqstxc'

At least the new size is consistent. Looking at the manifest file, the recorded size for gitgutter-20220524.tar.gz is the same as the recorded size for gitgutter-20180815.tar.gz, so my guess is I forgot to run "digest" after pkgbump.

What's a little concerning is how much larger the new version appears to be.

Comment 5 Thomas Bracht Laumann Jespersen 2022-06-01 07:51:21 UTC

Just for the record:

$ du -sh /var/cache/distfiles/gitgutter-20*
48K	/var/cache/distfiles/gitgutter-20180815.tar.gz
592K	/var/cache/distfiles/gitgutter-20220524.tar.gz

Comment 6 Thomas Bracht Laumann Jespersen 2022-06-01 07:54:51 UTC

I think this is the explanation:

$ find -name 'screenshot*' -exec du -h {} \;
16K	./gitgutter-20180815/work/gitgutter-20180815/screenshot.png
588K	./gitgutter-20220524/work/gitgutter-20220524/screenshot.png

Comment 7 Larry the Git Cow gentoo-dev

2022-06-03 03:14:53 UTC

The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=a4a3bee2cdc40b3c5719f9a8467faefbcc6d19c9

commit a4a3bee2cdc40b3c5719f9a8467faefbcc6d19c9
Author:     Thomas Bracht Laumann Jespersen <t@laumann.xyz>
AuthorDate: 2022-06-01 07:55:48 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2022-06-03 03:14:44 +0000

    app-vim/gitgutter: update Manifest
    
    Closes: https://bugs.gentoo.org/848906
    Signed-off-by: Thomas Bracht Laumann Jespersen <t@laumann.xyz>
    Closes: https://github.com/gentoo/gentoo/pull/25720
    Signed-off-by: Sam James <sam@gentoo.org>

 app-vim/gitgutter/Manifest | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)