Bug 848807

Summary:	media-libs/giflib-5.2.1-r1 fails test - make[1]: [makefile:134: giftext-regress] Error 1
Product:	Gentoo Linux	Reporter:	Toralf Förster <toralf>
Component:	Current packages	Assignee:	Codec Project <codec>
Status:	RESOLVED FIXED
Severity:	normal	CC:	kingjon3377
Priority:	Normal	Keywords:	TESTFAILURE
Version:	unspecified
Hardware:	All
OS:	Linux
See Also:	https://sourceforge.net/p/giflib/bugs/170/
Whiteboard:
Package list:		Runtime testing required:	---
Bug Depends on:
Bug Blocks:	847148
Attachments:	emerge-info.txt emerge-history.txt environment etc.portage.tar.bz2 media-libs:giflib-5.2.1-r1:20220531-145515.log temp.tar.bz2 tests.tar.bz2

Description Toralf Förster gentoo-dev

2022-05-31 16:52:31 UTC

gifsponge: Testing copy of ../pic/welcome2.gif
gifsponge: Testing copy of ../pic/x-trans.gif
giftext: Checking text dump of ../pic/fire.gif
*** Nonzero return status on ../pic/fire.gif!
make[1]: *** [makefile:134: giftext-regress] Error 1
make[1]: Leaving directory '/var/tmp/portage/media-libs/giflib-5.2.1-r1/work/giflib-5.2.1-abi_x86_64.amd64/tests'
make: *** [Makefile:87: check] Error 2

  -------------------------------------------------------------------

  This is an unstable amd64 chroot image at a tinderbox (==build bot)
  name: 17.1_systemd-j4_test-20220531-140159

  -------------------------------------------------------------------

gcc-config -l:
 [1] x86_64-pc-linux-gnu-12.1.1 *
clang/llvm (if any):
Python 3.9.12
php cli:

  HEAD of ::gentoo
commit 013aeebb70fe9197a844d6708047ea78df36d74c
Author: Repository mirror & CI <repomirrorci@gentoo.org>
Date:   Tue May 31 12:48:20 2022 +0000

    2022-05-31 12:48:19 UTC

emerge -qpvO media-libs/giflib
[ebuild  N    ] media-libs/giflib-5.2.1-r1  USE="-doc -static-libs" ABI_X86="(64) -32 (-x32)"

Comment 1 Toralf Förster gentoo-dev

2022-05-31 16:52:33 UTC

Created attachment 781655 [details]
emerge-info.txt

Comment 2 Toralf Förster gentoo-dev

2022-05-31 16:52:34 UTC

Created attachment 781658 [details]
emerge-history.txt

Comment 3 Toralf Förster gentoo-dev

2022-05-31 16:52:35 UTC

Created attachment 781661 [details]
environment

Comment 4 Toralf Förster gentoo-dev

2022-05-31 16:52:36 UTC

Created attachment 781664 [details]
etc.portage.tar.bz2

Comment 5 Toralf Förster gentoo-dev

2022-05-31 16:52:37 UTC

Created attachment 781667 [details]
media-libs:giflib-5.2.1-r1:20220531-145515.log

Comment 6 Toralf Förster gentoo-dev

2022-05-31 16:52:38 UTC

Created attachment 781670 [details]
temp.tar.bz2

Comment 7 Toralf Förster gentoo-dev

2022-05-31 16:52:39 UTC

Created attachment 781673 [details]
tests.tar.bz2

Comment 8 Larry the Git Cow gentoo-dev

2024-05-30 03:54:13 UTC

The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=033629cddfc22d7bcead70daa7b6eaa76f0bc623

commit 033629cddfc22d7bcead70daa7b6eaa76f0bc623
Author:     Sam James <sam@gentoo.org>
AuthorDate: 2024-05-30 03:50:58 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2024-05-30 03:53:53 +0000

    media-libs/giflib: add 5.2.2
    
    The release notes mention CVE-2023-48161 and CVE-2022-28506 by CVE but
    there's a bunch of other security fixes in the list of fixes.
    
    The documentation in this release also adds:
    """
    +<refsect1><title>Bugs</title>
    +
    +<para>Feeding this utility a GIF with an invalid colormap, or other
    +kinds of malformations, index will produce invalid output and may
    +core-dump the tool. Don't do that.</para>
    +
    +</refsect1>
    """
    
    Anyway, on the ebuild side:
    * Replace Makefile patch for doc building conditionally with a sed
    * Make tests more verbose (needed it when debugging bug #848807)
    * Cleanup reallocarray hack (bug #677956)
    * Add LFS support (bug #915316)
    
    Bug: https://bugs.gentoo.org/677956
    Bug: https://bugs.gentoo.org/785664
    Bug: https://bugs.gentoo.org/851945
    Bug: https://bugs.gentoo.org/918539
    Closes: https://bugs.gentoo.org/848807
    Closes: https://bugs.gentoo.org/915316
    Signed-off-by: Sam James <sam@gentoo.org>

 media-libs/giflib/Manifest                         |  1 +
 media-libs/giflib/files/giflib-5.2.2-fortify.patch | 27 ++++++++
 .../giflib/files/giflib-5.2.2-verbose-tests.patch  | 74 +++++++++++++++++++++
 media-libs/giflib/giflib-5.2.2.ebuild              | 76 ++++++++++++++++++++++
 4 files changed, 178 insertions(+)