Bug 84688 – net-mail/courier-imap ebuild cleanup (needs bump)

• Product: Gentoo/Alt
• Status: RESOLVED FIXED

[Description Diego Elio Pettenò (RETIRED) 2005-03-09 17:08:09 UTC]

The attached patch applied over current ebuild removes dependency on procps (on fbsd it will build without it without a glitch, I don't know about linux systems but it seems a strange dependency to me).

It also clean up econf call moving --without-redhat here instead of a $myconf addition (it should go without saying that we aren't using redhat :) ) and finally move here also ipv6 and fam instead of having them somewhere else.

Note: courier-imap-4.0.1, and 4.0.1-r1 doesn't build at all on fbsd. 4.0.2 does, but isn't in portage as for now.

[Comment 1 Diego Elio Pettenò (RETIRED) 2005-03-09 17:08:25 UTC]

Created attachment 53046 [details, diff]
Patch over current ebuild

[Comment 2 Diego Elio Pettenò (RETIRED) 2005-04-12 18:29:46 UTC]

Maybe I should have CCed before the maintainer :)

[Comment 3 Robin Johnson 2005-04-12 18:51:12 UTC]

procps is there because it courier-imap needs sysctl to build, and previous versions did make use of other binaries there, but I think most of that has been cut down in the new v4 releases. If freebsd offers all of the binaries that procps has, they should probably have a package.provided in their profile to satisfy the dep.

for patches that clean up specific configure flags, please do NOT remove the comments. Several times in the past the '--without-redhat' flag was removed by unknown parties, and things then failed for anybody that happened to have a binary named 'rpm' (yes, that is the entirely of upstreams 'redhat' check).

[Comment 4 Diego Elio Pettenò (RETIRED) 2005-04-12 19:19:55 UTC]

Grepping for sysctl on courier-imap sources does only found config.guess, in a case statement for NetBSD.

Also, --without-readhat check is no more on rpm, at least if it's on that, it's not on configure, as there it uses config.guess output, so if there's no other checks for it, it could be also removed (also --without-redhat is just the default, it's a complete no-op).

[Comment 5 Robin Johnson 2005-04-12 19:39:29 UTC]

could you perhaps ask on the upstream mailing list if the procps is still needed for anything?

[Comment 6 Diego Elio Pettenò (RETIRED) 2005-04-12 20:00:55 UTC]

Created attachment 56140 [details, diff]
courier-imap-4.0.2.patch

I'm not subscribed to upstream ml, i'll take a look to subscribe tomorrow if
needed (here is quite 5am, and i haven't slept :P).

This patch anyway cleans the ebuild a bit more up: it fixes sed to use -i -e
intead of -e -i (it also breaks a double sed which would have failed on bsdish
sed, I know it's not an issue, but this wouldn't change anything anyway), and
uses newinitd instead of exeinto/newexe.

Also, currently courier-imap overwrites pam.d files from mailbase, shouldn't
this be avoided removing ${D}/etc/pam.d?
And about nls useflag, as it's related to unicode, can't be changed into
unicode useflag? I have no nls useflag but I have nls useflag, now i'm using
+nls on courier-imap from package.use.

Finally, the attached patch also removes dependency on sed-4 as it's in profile
anyway now.

[Comment 7 Diego Elio Pettenò (RETIRED) 2005-04-12 20:27:26 UTC]

Created attachment 56142 [details, diff]
courier-imap-4.0.2.patch

This patch is a bit more complex, but adds two INITD_VER and RC_VER params to
the ebuild to make simpler bumping to 4.0.2.

[Comment 8 Diego Elio Pettenò (RETIRED) 2005-05-19 05:43:52 UTC]

Note: courier-imap collides with mailbase on pamd files. 

[Comment 9 Alex V. Koval 2005-06-19 05:55:55 UTC]

interesting who is maintainer for courier-imap package now? I have spent 3 hours
today, and found that courier-imap-4.0.1 which is marked stable in fact have a
problems with relay-ctrl

after upgrading to ~4.0.1-r1 problem disappears. I am absolutely sure we need a
version bump here. and of coruse include 4.0.2 to portage as well

[Comment 10 Diego Elio Pettenò (RETIRED) 2005-07-16 04:06:35 UTC]

Robin if it's still an issue we can just put procps in an userland_GNU? or 
kernel_linux? conditional. 
In this case it gets installed on G/Linux but not on G/*. 
 
 

[Comment 11 Diego Elio Pettenò (RETIRED) 2005-07-31 09:23:08 UTC]

Robin if you can't take care of this, I can maintain this. Latest version is 
4.0.4 now. 
 

[Comment 12 Jakub Moc (RETIRED) 2005-07-31 09:47:45 UTC]

*** Bug 100901 has been marked as a duplicate of this bug. ***

[Comment 13 Diego Elio Pettenò (RETIRED) 2005-08-08 02:58:37 UTC]

4.0.4 with cleanups is in portage. 
 

[Comment 14 Tuan Van (RETIRED) 2005-08-11 16:14:15 UTC]

Diego,
a little DEPEND problem here.
# emerge '<courier-auhtlib-0.57'
# emerge courier-imap
>>> emerge (1 of 1) net-mail/courier-imap-4.0.4 to /
<snip>
configure: error: Courier authentication library version 0.57 required.

[Comment 15 Diego Elio Pettenò (RETIRED) 2005-08-12 01:01:35 UTC]

Sorry it was in my overlay but i forgot to re-write it when i moved to   
gentoo-x86 checkout (it was out of sync so I haven't copied it over and  
rewrote it).  
  
Committing.