Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!

Bug 846506

Summary: sci-mathematics/singular upstream bump to 4.3.0_p1
Product: Gentoo Linux Reporter: François Bissey <frp.bissey>
Component: Current packagesAssignee: Gentoo Science Mathematics related packages <sci-mathematics>
Status: RESOLVED FIXED    
Severity: normal CC: frp.bissey
Priority: Normal Keywords: PullRequest
Version: unspecified   
Hardware: All   
OS: Linux   
See Also: https://github.com/gentoo/gentoo/pull/25564
Whiteboard:
Package list:
Runtime testing required: ---
Bug Depends on:    
Bug Blocks: 841248    

Description François Bissey 2022-05-19 22:04:58 UTC
A new version of singular is out and makes two of our patch for 4.3.0 redundant. Unfortunately, it doesn't include upstream fix for #841248.

I am preparing a branch for this. I plan to do the following:
* bump to 4.3.0_p1
* backport fix for #841248
* clean 4.3.0 and associated patches
* insert myself as proxy maintainer as agreed in the last bump.

Guidance on how you want the branch to be structured welcome.

Reproducible: Always
Comment 1 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2022-05-19 22:08:12 UTC
I think your plan sounds reasonable in individual commits. Feel free to stuff in the backport with the first commit, but feel free not to as well.
Comment 2 François Bissey 2022-05-19 22:11:26 UTC
Guidance request: Should I "sign off" each commit individually? (I would say yes) And should I mention this bug in the first or last commit (or all)?
Comment 3 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2022-05-20 00:04:53 UTC
(In reply to François Bissey from comment #2)
> Guidance request: Should I "sign off" each commit individually? (I would say
> yes) And should I mention this bug in the first or last commit (or all)?

1. yes
2. up to you, I'd probably just do bump + backport commit tagged with bug
Comment 4 François Bissey 2022-05-20 00:06:53 UTC
Glad, I won't have to redo then :)
Comment 5 Larry the Git Cow gentoo-dev 2022-05-27 12:23:05 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=f5023f5ed66a4ca62a253c7915f73382e28380c2

commit f5023f5ed66a4ca62a253c7915f73382e28380c2
Author:     Michael Orlitzky <mjo@gentoo.org>
AuthorDate: 2022-05-27 12:14:34 +0000
Commit:     Michael Orlitzky <mjo@gentoo.org>
CommitDate: 2022-05-27 12:20:10 +0000

    sci-mathematics/singular: drop unused flag-o-matic inherit.
    
    The append-cxxflags that this was used for is obsolete in the latest
    version; thusly the eclass.
    
    Closes: https://github.com/gentoo/gentoo/pull/25564
    Closes: https://bugs.gentoo.org/846506
    Package-Manager: Portage-3.0.30, Repoman-3.0.3
    Signed-off-by: Michael Orlitzky <mjo@gentoo.org>

 sci-mathematics/singular/singular-4.3.0_p1.ebuild | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Additionally, it has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=27fc1d71c4ddc09c93fa8d229d9ef1991ca35196

commit 27fc1d71c4ddc09c93fa8d229d9ef1991ca35196
Author:     François Bissey <frp.bissey@gmail.com>
AuthorDate: 2022-05-19 23:28:38 +0000
Commit:     Michael Orlitzky <mjo@gentoo.org>
CommitDate: 2022-05-27 11:57:31 +0000

    sci-mathematics/singular: Add François Bissey as proxy maintainer
    
    Package-Manager: Portage-3.0.30, Repoman-3.0.3
    Bug: https://bugs.gentoo.org/846506
    Signed-off-by: François René Pierre Bissey <frp.bissey@gmail.com>
    Signed-off-by: Michael Orlitzky <mjo@gentoo.org>

 sci-mathematics/singular/metadata.xml | 8 ++++++++
 1 file changed, 8 insertions(+)