| Summary: | sys-apps/xdg-desktop-portal : depend on any of xdg-desktop-portal-* implementations | ||
|---|---|---|---|
| Product: | Gentoo Linux | Reporter: | Shiba <shibotto> |
| Component: | Current packages | Assignee: | Gentoo KDE team <kde> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | gnome, sam, zmedico |
| Priority: | Normal | ||
| Version: | unspecified | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Package list: | Runtime testing required: | --- | |
|
Description
Shiba
2022-05-17 06:42:14 UTC
*/xdg-desktop-portal-{kde,lxqt,gnome,gtk,wlr} packages all depend on xdg-desktop-portal, so this would create a circular dependency unless PDEPEND is used.
I don't think it is necessary to make a dependency here, rather it creates potential for unwanted/unsuitable portal implementation deps for someone installing sys-apps/flatpak without pre-existing portal-* package. It is up to the DEs' meta packages to provide the facilities for flatpak integration, and people who "go minimal" will be used to choose the portal impl on their own.
For them, a postinst message can be provided, otoh why spam everyone else with something they get as a dependency of their portal-* implementation. So maybe it should be made on the condition of none of the known implementations being present.
Oh I'm not using any desktop package, so I was surprised when --depclean tried to remove xdg-desktop-portal-gtk and I thought it was an unintended side effect, but that makes sense now. I'm voting in favor of the conditional postinst message, after all a portal implementation is required and this seems like a nice reminder. What do others think? Also, at least for Qt this change was added to fall back to native dialog in case no XDP impl available: https://invent.kde.org/qt/qt/qtbase/-/merge_requests/177 https://bugreports.qt.io/browse/QTBUG-98988 > Add QXdgDesktopPortalFileDialog::useNativeFileDialog() > Fallback to another file dialog implementation when XDP is inaccessible (In reply to Andreas Sturmlechner from comment #3) > What do others think? I think it makes sense to optfeature if none of them are installed. The bug has been closed via the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=1319a6905b4ff4ef1cba89e35c53d70691cb79b8 commit 1319a6905b4ff4ef1cba89e35c53d70691cb79b8 Author: Andreas Sturmlechner <asturm@gentoo.org> AuthorDate: 2022-10-10 18:07:42 +0000 Commit: Andreas Sturmlechner <asturm@gentoo.org> CommitDate: 2022-10-10 18:09:12 +0000 sys-apps/xdg-desktop-portal: Add pkg_postinst info about XDP impls Closes: https://bugs.gentoo.org/845138 Signed-off-by: Andreas Sturmlechner <asturm@gentoo.org> .../xdg-desktop-portal/xdg-desktop-portal-1.15.0.ebuild | 14 ++++++++++++++ 1 file changed, 14 insertions(+) |
