Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!

Bug 844898

Summary: media-sound/pulseeffects-4.8.6 fails compilation with dev-libs/boost-1.79.0
Product: Gentoo Linux Reporter: Sven Hesse <drmccoy>
Component: Current packagesAssignee: Marek Szuba (RETIRED) <marecki>
Status: RESOLVED FIXED    
Severity: normal CC: prometheanfire
Priority: Normal Keywords: PATCH
Version: unspecified   
Hardware: All   
OS: Linux   
See Also: https://bugs.gentoo.org/show_bug.cgi?id=849059
Whiteboard:
Package list:
Runtime testing required: ---
Bug Depends on:    
Bug Blocks: 808087    
Attachments: Patch that fixes compilation of media-sound/pulseeffects-4.8.6 with dev-libs/boost-1.79.0

Description Sven Hesse 2022-05-15 17:31:48 UTC 
Created attachment 779123 [details, diff]
Patch that fixes compilation of media-sound/pulseeffects-4.8.6 with dev-libs/boost-1.79.0

pulseeffects fails to compile with Boost 1.79.0 due to a change in Boost.Filesystem's main header.

Boost.Filesystem in Boost 1.79.0 changed the already-deprecated header of string_file.hpp to be not included by default anymore in its commit 266e1ac892a6f54d807fb35bf639a9aa1c8b2db1: https://github.com/boostorg/filesystem/commit/266e1ac892a6f54d807fb35bf639a9aa1c8b2db1

Boost.Filesystem's fstream.hpp was never included directly by default, but string_file.hpp did include it, so src/general_settings_ui.cpp in PulseEffects compiled fine until now. With Boost 1.79.0, though, it explodes in line 179.

I'm attaching a patch that fixes compilation in Gentoo. I've already filed a pull request with upstream too here: https://github.com/wwmm/easyeffects/pull/1529

GCO sign-off for the patch:
Signed-off-by: Sven Hesse <drmccoy@drmccoy.de>
Comment 1 Larry the Git Cow gentoo-dev 2022-05-15 21:01:58 UTC 
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=efcf421ff9e351b8003a1ca60d107b766f099461

commit efcf421ff9e351b8003a1ca60d107b766f099461
Author:     Sam James <sam@gentoo.org>
AuthorDate: 2022-05-15 20:59:48 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2022-05-15 21:00:40 +0000

    media-sound/pulseeffects: fix build with Boost 1.79
    
    Closes: https://bugs.gentoo.org/844898
    Thanks-to: Sven Hesse <drmccoy@drmccoy.de>
    Signed-off-by: Sam James <sam@gentoo.org>

 .../files/pulseeffects-4.8.6-boost_1.79.patch      | 25 ++++++++++++++++++++++
 media-sound/pulseeffects/pulseeffects-4.8.6.ebuild |  1 +
 2 files changed, 26 insertions(+)