Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!

Bug 844178

Summary: net-misc/netifrc-0.7.7 installs shell script that uses non-POSIX features
Product: Gentoo Linux Reporter: Agostino Sarubbo <ago>
Component: Current packagesAssignee: netifrc Team <netifrc>
Status: RESOLVED FIXED    
Severity: normal CC: kfm, matoro_bugzilla_gentoo, robbat2, srcshelton
Priority: Normal Keywords: InVCS, PullRequest
Version: unspecified   
Hardware: All   
OS: Linux   
URL: https://github.com/gentoo/netifrc/pull/50
See Also: https://bugs.gentoo.org/show_bug.cgi?id=849227
Whiteboard:
Package list:
Runtime testing required: ---
Bug Depends on:    
Bug Blocks: 609070    
Attachments: build.log

Description Agostino Sarubbo gentoo-dev 2022-05-14 11:20:19 UTC
https://blogs.gentoo.org/ago/2020/07/04/gentoo-tinderbox/

Issue: net-misc/netifrc-0.7.3 installs shell script that uses non-POSIX features.
Discovered on: amd64 (internal ref: ci)
Comment 1 Agostino Sarubbo gentoo-dev 2022-05-14 11:20:21 UTC
Created attachment 778775 [details]
build.log

build log and emerge --info
Comment 2 kfm 2022-05-14 12:49:03 UTC
The type utility is not a bashism, in and as of itself. However, it is part of the XSI extension, meaning that an sh(1) implementation may refrain from implementing it while still being considered as POSIX-conforming. It could be written as "command -v resolvconf >/dev/null" instead. Note that STDERR need not be silenced in that case.
Comment 3 Agostino Sarubbo gentoo-dev 2022-05-20 07:22:51 UTC
ci has reproduced this issue with version 0.7.3-r1 - Updating summary.
Comment 4 Agostino Sarubbo gentoo-dev 2023-04-17 07:41:49 UTC
ci has reproduced this issue with version 0.7.4 - Updating summary.
Comment 5 Agostino Sarubbo gentoo-dev 2023-05-29 06:03:57 UTC
ci has reproduced this issue with version 0.7.5 - Updating summary.
Comment 6 Agostino Sarubbo gentoo-dev 2023-09-11 06:51:15 UTC
ci has reproduced this issue with version 0.7.6 - Updating summary.
Comment 7 Agostino Sarubbo gentoo-dev 2024-01-03 08:52:43 UTC
gcc14_tinderbox has reproduced this issue with version 0.7.7 - Updating summary.
Comment 8 Larry the Git Cow gentoo-dev 2024-01-07 09:42:39 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/proj/netifrc.git/commit/?id=6b54da4cc0b85aaed4e4546bbb0893476fb6835c

commit 6b54da4cc0b85aaed4e4546bbb0893476fb6835c
Author:     Matoro Mahri <matoro_gentoo@matoro.tk>
AuthorDate: 2024-01-03 15:37:03 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2024-01-07 09:42:33 +0000

    net.lo.in: replace "type" bashism with "command"
    
    Closes: https://bugs.gentoo.org/844178
    Signed-off-by: Matoro Mahri <matoro_gentoo@matoro.tk>
    Closes: https://github.com/gentoo/netifrc/pull/50
    Signed-off-by: Sam James <sam@gentoo.org>

 init.d/net.lo.in | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Comment 9 Larry the Git Cow gentoo-dev 2024-01-07 09:45:04 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=ae91de64d73dcba407c178a53252d2b547ee40c8

commit ae91de64d73dcba407c178a53252d2b547ee40c8
Author:     Sam James <sam@gentoo.org>
AuthorDate: 2024-01-07 09:44:40 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2024-01-07 09:44:49 +0000

    net-misc/netifrc: add 0.7.8
    
    Bug: https://bugs.gentoo.org/844178
    Bug: https://bugs.gentoo.org/921538
    Signed-off-by: Sam James <sam@gentoo.org>

 net-misc/netifrc/Manifest             |  1 +
 net-misc/netifrc/netifrc-0.7.8.ebuild | 91 +++++++++++++++++++++++++++++++++++
 2 files changed, 92 insertions(+)