Summary: | dev-util/android-tools-31.0.3_p1 won't compile with GCC 12.1 | ||
---|---|---|---|
Product: | Gentoo Linux | Reporter: | Mike Lothian <mike> |
Component: | Current packages | Assignee: | Zac Medico <zmedico> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | marcelo.ru, sam, toralf |
Priority: | Normal | Keywords: | PATCH |
Version: | unspecified | ||
Hardware: | All | ||
OS: | Linux | ||
URL: | https://github.com/nmeum/android-tools/issues/60 | ||
See Also: | https://bugs.gentoo.org/show_bug.cgi?id=870337 | ||
Whiteboard: | |||
Package list: | Runtime testing required: | --- | |
Bug Depends on: | |||
Bug Blocks: | 839906 | ||
Attachments: | Hopefully non-mangled patch |
Description
Mike Lothian
2022-05-14 01:28:48 UTC
The bug has been closed via the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=9b60f64b5be8e35a125b92cc0ef957f5e2186c7c commit 9b60f64b5be8e35a125b92cc0ef957f5e2186c7c Author: Sam James <sam@gentoo.org> AuthorDate: 2022-05-14 01:38:06 +0000 Commit: Sam James <sam@gentoo.org> CommitDate: 2022-05-14 01:38:06 +0000 dev-util/android-tools: fix build with GCC 12 Closes: https://bugs.gentoo.org/844127 Thanks-to: Mike Lothian <mike@fireburn.co.uk> Signed-off-by: Sam James <sam@gentoo.org> dev-util/android-tools/android-tools-31.0.3_p1.ebuild | 4 +++- .../files/android-tools-31.0.3_p1-gcc12.patch | 15 +++++++++++++++ 2 files changed, 18 insertions(+), 1 deletion(-) What about the the SELinux issue? (In reply to Mike Lothian from comment #2) > What about the the SELinux issue? Dunno? :) It wasn't clear to me that it actually failed on it or if you were just sharing a warning you saw, given no log. I'm guessing it did in fact fail to build? Sorry I thought I pasted in the warning from portage * QA Notice: Package triggers severe warnings which indicate that it * may exhibit random runtime failures. * /var/tmp/portage/dev-util/android-tools-31.0.3_p1/work/android-tools-31.0.3p1/vendor/selinux/libselinux/src/label_file.h:289:25: warning: ‘free’ called on pointer ‘mmap_area_89->next_addr’ with nonzero offset 4 [-Wfree-nonheap-object] * Please do not file a Gentoo bug and instead report the above QA * issues directly to the upstream developers of this software. * Homepage: https://github.com/nmeum/android-tools/ https://developer.android.com/ https://github.com/SELinuxProject/selinux/commit/6e5d16a012e1845774da106846b87090d39ea8f3.patch Also sam_ complained about my patch [02:34] <sam_> FireBurnUK: patch mangler :( [02:35] <sam_> patching file tls/include/adb/tls/tls_connection.h [02:35] <sam_> patch: **** unexpected end of file in patch I'll attach a properly formatted patch to the bug Created attachment 778661 [details, diff]
Hopefully non-mangled patch
*** Bug 840179 has been marked as a duplicate of this bug. *** *** Bug 848861 has been marked as a duplicate of this bug. *** It's a real pain to apply patches to the bundled components and I'm not even sure if it actually matters here for this -- I'm inclined to close this as the GCC 12 issue is fixed, and I hope there'll be a new release soon w/ new SELinux anyway, but Zac is free ofc to apply the patch if he wants to. (In reply to Sam James from comment #8) > It's a real pain to apply patches to the bundled components and I'm not even > sure if it actually matters here for this -- I'm inclined to close this as > the GCC 12 issue is fixed, and I hope there'll be a new release soon w/ new > SELinux anyway, but Zac is free ofc to apply the patch if he wants to. (If you made a PR to add the selinux patch to it, I'd merge it though) |