Bug 844070

Summary:	mail-client/alpine should recommend app-text/hunspell or app-text/aspell as optfeature for spell checking
Product:	Gentoo Linux	Reporter:	CFuga <cfuga>
Component:	Current packages	Assignee:	Robert G. Siebeck <gentoo.2019>
Status:	RESOLVED FIXED
Severity:	enhancement	CC:	proxy-maint
Priority:	Normal	Keywords:	PullRequest
Version:	unspecified
Hardware:	All
OS:	Linux
See Also:	https://github.com/gentoo/gentoo/pull/25653
Whiteboard:
Package list:		Runtime testing required:	---
Attachments:	Optional spell checking for net-mail/alpine

Description CFuga 2022-05-13 17:19:40 UTC

Right now, mail-client/alpine depends on app-text/aspell, when the spell USE flag is set.

But the configure script for alpine also supports hunspell since 2009, when it was known as re-alpine.

https://marc.info/?l=alpine-info&m=124929025412411&w=2

And the configure script only sets the initial value for the spell checking program. Users could change it without recompiling, setting the speller= option in .pinerc, /etc/pinerc, or even using the command line:

alpine -speller="hunspell -l"
alpine -speller="aspell --dont-backup --mode=email list"

My patch for alpine-2.25.ebuild, attached to this bug, has the following changes:

* Removes the spell USE flag
* Allows configure to set hunspell or aspell as the default spell checking program for alpine, if any of them is installed
* Suggests app-text/hunspell or app-text/aspell for spell checking, if they're not installed

Reproducible: Always

Comment 1 CFuga 2022-05-13 17:20:15 UTC

Created attachment 778538 [details, diff]
Optional spell checking for net-mail/alpine

Comment 2 Larry the Git Cow gentoo-dev

2022-06-10 02:45:15 UTC

The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=d617bdfd3f51545a4e7e4c0150ab418c574d4394

commit d617bdfd3f51545a4e7e4c0150ab418c574d4394
Author:     Robert Siebeck <gentoo.2019@r123.de>
AuthorDate: 2022-05-26 22:05:26 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2022-06-10 02:28:12 +0000

    mail-client/alpine: add version 2.25-r3
    
    Support for multiple spellchecking backends
    
    Co-authored-by: CFuga <cfuga@cfuga.mx>
    Closes: https://bugs.gentoo.org/844070
    Signed-off-by: Robert Siebeck <gentoo.2019@r123.de>
    Closes: https://github.com/gentoo/gentoo/pull/25653
    Signed-off-by: Sam James <sam@gentoo.org>

 mail-client/alpine/alpine-2.25-r3.ebuild | 97 ++++++++++++++++++++++++++++++++
 1 file changed, 97 insertions(+)