Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!

Bug 843713

Summary: ghc-package.eclass uses a reserved function name
Product: Gentoo Linux Reporter: Ulrich Müller <ulm>
Component: EclassesAssignee: Gentoo's Haskell Language team <haskell>
Status: RESOLVED FIXED    
Severity: QA CC: qa
Priority: Lowest Keywords: PullRequest
Version: unspecified   
Hardware: All   
OS: Linux   
See Also: https://github.com/gentoo/gentoo/pull/25521
Whiteboard:
Package list:
Runtime testing required: ---
Bug Depends on:    
Bug Blocks: 843680    

Description Ulrich Müller gentoo-dev 2022-05-11 06:52:34 UTC
Function names ghc-is-dynamic and ghc-extractportageversion are reserved names and must not be used.

Policy reference:
https://projects.gentoo.org/pms/8/pms.html#x1-13700012.3.17
Comment 1 Ulrich Müller gentoo-dev 2022-05-13 19:49:34 UTC
(In reply to Ulrich Müller from comment #0)
> Function names ghc-is-dynamic

After the PMS update from bug 843779, this name will no longer be an issue.

> and ghc-extractportageversion

This still is.

> are reserved names and must not be used.
Comment 2 Larry the Git Cow gentoo-dev 2022-05-20 17:15:37 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=5c8a87ee8b208cccf1ff94a7b4a7f28c45a9f13f

commit 5c8a87ee8b208cccf1ff94a7b4a7f28c45a9f13f
Author:     Ulrich Müller <ulm@gentoo.org>
AuthorDate: 2022-05-16 06:24:59 +0000
Commit:     Ulrich Müller <ulm@gentoo.org>
CommitDate: 2022-05-20 17:15:04 +0000

    ghc-package.eclass: Avoid reserved function name
    
    Rename function ghc-extractportageversion to ghc-extract-pm-version.
    
    Closes: https://bugs.gentoo.org/843713
    Signed-off-by: Ulrich Müller <ulm@gentoo.org>

 eclass/ghc-package.eclass | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

Additionally, it has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=a4580b5ec680ccc90ed70b16843e142ee29f88ac

commit a4580b5ec680ccc90ed70b16843e142ee29f88ac
Author:     Ulrich Müller <ulm@gentoo.org>
AuthorDate: 2022-05-16 06:26:44 +0000
Commit:     Ulrich Müller <ulm@gentoo.org>
CommitDate: 2022-05-20 17:15:04 +0000

    haskell-cabal.eclass: Update function call
    
    ghc-extractportageversion was renamed to ghc-extract-pm-version.
    
    Bug: https://bugs.gentoo.org/843713
    Signed-off-by: Ulrich Müller <ulm@gentoo.org>

 eclass/haskell-cabal.eclass | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)