| Summary: | mail-client/clawsker-1.3.5 fails tests | ||
|---|---|---|---|
| Product: | Gentoo Linux | Reporter: | Agostino Sarubbo <ago> |
| Component: | Current packages | Assignee: | No maintainer - Look at https://wiki.gentoo.org/wiki/Project:Proxy_Maintainers if you want to take care of it <maintainer-needed> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | juippis, kuraga333, sam |
| Priority: | Normal | Keywords: | PullRequest |
| Version: | unspecified | ||
| Hardware: | All | ||
| OS: | Linux | ||
| See Also: | https://github.com/gentoo/gentoo/pull/25741 | ||
| Whiteboard: | |||
| Package list: | Runtime testing required: | --- | |
| Attachments: | build.log | ||
|
Description
Agostino Sarubbo
2022-04-29 14:55:05 UTC
CC'ing also the author of the commit (91fa6615578f4a3d0a35ad59ccda54cd2218c770) Created attachment 775332 [details]
build.log
build log and emerge --info
Error(s) that match a know pattern: Error: '/notexisting' is not a directory or does not exist Good day, Agostino! 1. Do I understand build log correct: it is a test error? 2. How can I reproduce this? 3. If p.1 is correct, could this diff provide the error? -BDEPEND="test? ( dev-perl/Test-Exception )" +DEPEND="test? ( dev-perl/Test-Exception )" 4. If I can't reproduce: did this fail on 1.3.4? Thanks! (In reply to Alexander Kurakin from comment #4) > Good day, Agostino! > > 1. Do I understand build log correct: it is a test error? > > 2. How can I reproduce this? > > 3. If p.1 is correct, could this diff provide the error? > > -BDEPEND="test? ( dev-perl/Test-Exception )" > +DEPEND="test? ( dev-perl/Test-Exception )" > > 4. If I can't reproduce: did this fail on 1.3.4? > > Thanks! BDEPEND vs DEPEND should be fine here. Yeah, it's a test error: t/get_screen_height.t ......... Can't locate Test/NeedsDisplay.pm in @INC (you may need to install the Test::NeedsDisplay module) (@INC contains: /var/tmp/portage/mail-client/clawsker-1.3.5/work/clawsker-1.3.5/t /etc/perl /usr/local/lib64/perl5/5.34/x86_64-linux-thread-multi /usr/local/lib64/perl5/5.34 /usr/lib64/perl5/vendor_perl/5.34/x86_64-linux-thread-multi /usr/lib64/perl5/vendor_perl/5.34 /usr/lib64/perl5/5.34/x86_64-linux-thread-multi /usr/lib64/perl5/5.34) at t/get_screen_height.t line 4. BEGIN failed--compilation aborted at t/get_screen_height.t line 4. t/get_screen_height.t ......... Dubious, test returned 2 (wstat 512, 0x200) The way to reproduce this is likely a minimal chroot. Did tests pass for you? I don't see Test::NeedsDisplay packaged in Gentoo. We may need to make an ebuild for it. (It might be that Test::NeedsDisplay isn't needed if you have X running or something?) For some reason pkg-testing-tool doesn't recognize the test phase is available. # pkg-testing-tool --extra-env-file 'test.conf' --test-feature-scope always --max-use-combinations 1 -p '=mail-client/clawsker-1.3.5' [INFO] >>> Following testing jobs will be executed: =mail-client/clawsker-1.3.5 USE: <default flags> [INFO] >>> Running (1 of 1) =mail-client/clawsker-1.3.5 with USE: <default flags> These are the packages that would be merged, in order: Calculating dependencies ..... done! [ebuild R ] mail-client/clawsker-1.3.5::gentoo USE="-test" 0 KiB If I manually force it with FEATURES="test" USE="test" pkg-testing-tool ... then I get the same error. Thank you for instructions! Confirm: tests pass in 1.3.4 and fail in 1.3.5. Seems like https://git.claws-mail.org/?p=clawsker.git;a=commitdiff;h=e7597f602bd0198c3f7f34e7496d7f5962c08cdd is an originator. What we have to do? Have we restrict testing? (In reply to Alexander Kurakin from comment #8) > What we have to do? Have we restrict testing? "Did tests pass for you? I don't see Test::NeedsDisplay packaged in Gentoo. We may need to make an ebuild for it." We package the new test dependency then add it as a test dependency to this ebuild. [month after report] Test::NeedsDisplay Perl package is absent. Is it allowed to have broken tests in repository? If no, should we restrict tests? Should we patch tests? Thanks. (In reply to Alexander Kurakin from comment #10) > [month after report] > > Test::NeedsDisplay Perl package is absent. > > Is it allowed to have broken tests in repository? > > If no, should we restrict tests? Should we patch tests? > > Thanks. We just package the new test dependency like I said above? (In reply to Sam James from comment #11) > (In reply to Alexander Kurakin from comment #10) > > [month after report] > > > > Test::NeedsDisplay Perl package is absent. > > > > Is it allowed to have broken tests in repository? > > > > If no, should we restrict tests? Should we patch tests? > > > > Thanks. > > We just package the new test dependency like I said above? Yes but before this? (In reply to Alexander Kurakin from comment #12) > (In reply to Sam James from comment #11) > > (In reply to Alexander Kurakin from comment #10) > > > [month after report] > > > > > > Test::NeedsDisplay Perl package is absent. > > > > > > Is it allowed to have broken tests in repository? > > > > > > If no, should we restrict tests? Should we patch tests? > > > > > > Thanks. > > > > We just package the new test dependency like I said above? > > Yes but before this? Well, ideally, just package it now if you can, it should be a quick job. But if for some reason that couldn't be done, we can either skip the relevant tests, or least favourably, restrict tests entirely. (In reply to Sam James from comment #13) > Well, ideally, just package it now if you can, it should be a quick job. Sorry I'm not aware of Perl. Sure I would already done this otherwise. Removed broken test in https://github.com/gentoo/gentoo/pull/25741. The bug has been closed via the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=c0fb0f79c87216d5af70d632d9d6612db11b3de5 commit c0fb0f79c87216d5af70d632d9d6612db11b3de5 Author: Alexander Kurakin <kuraga333@mail.ru> AuthorDate: 2022-06-03 15:14:17 +0000 Commit: Lars Wendler <polynomial-c@gentoo.org> CommitDate: 2022-06-08 07:27:42 +0000 mail-client/clawsker-1.3.5: remove failed test Remove `get_screen_height` test as it requires absent Test::NeedsDisplay Perl package Closes: https://bugs.gentoo.org/841707 Signed-off-by: Alexander Kurakin <kuraga333@mail.ru> Closes: https://github.com/gentoo/gentoo/pull/25741 Signed-off-by: Lars Wendler <polynomial-c@gentoo.org> mail-client/clawsker/clawsker-1.3.5.ebuild | 5 +++++ .../clawsker-remove-get_screen_height-test.patch | 23 ++++++++++++++++++++++ 2 files changed, 28 insertions(+) |
