Bug 84030 – howl 0.9.8 fails to compile with parse errors

• Product: Gentoo Linux
• Status: RESOLVED FIXED

[Description Sven E. 2005-03-03 19:54:36 UTC]

While trying to compiel howl 0.9.8 I get a whole bunch of parse errors etc. in some header that's being included. A short look at the header didn't really show anything unsusual

Reproducible: Always
Steps to Reproduce:
1. Trying to emerge howl 0.9.8
2.
3.




Attachment follows ...

[Comment 1 Sven E. 2005-03-03 19:58:03 UTC]

Created attachment 52613 [details]
Snippet of the error output

This is a short snippet of the parse errors I am getting, I will attach the
beginning of the header as well, maybe anyone sees something unusual in it ...

[Comment 2 Sven E. 2005-03-03 20:02:34 UTC]

Created attachment 52614 [details]
Beginning of the header with the parse errors

It's just the first part of the header, the struct definition doesn't look
unusual to me - I don't see any reason for a parse error in it.

Any deas/Recommendations ?

[Comment 3 Forza 2005-03-09 13:45:48 UTC]

The same error occur with howl-0.9.10 too.

[Comment 4 Robin Princeley 2005-03-10 06:12:50 UTC]

Missing types in posix_interface.c. The kernel header types.h defines required datatypes.

Add #include <linux/types.h> before other kernel headers:

#if defined(__linux__)
typedef unsigned long long u64;
typedef __uint32_t      u32;
typedef __uint16_t      u16;
typedef __uint8_t               u8;
#       include <linux/types.h>    /* <---- */
#       include <linux/sockios.h>
#       include <linux/ethtool.h>
#endif

[Comment 5 Greg Symons 2005-03-12 20:26:12 UTC]

Created attachment 53304 [details, diff]
adds #include <linux/types.h> to posix_interface.c

I rolled the above change into a patch, and everything compiled cleanly on
amd64. I've got a new ebuild, too. I'll upload that after this attachment.

[Comment 6 Greg Symons 2005-03-12 20:28:08 UTC]

Created attachment 53305 [details]
new ebuild to incorporate the missing types patch

Here's the ebuild which incorporates the missing types patch

[Comment 7 Stefan Knoblich (RETIRED) 2005-03-13 00:40:25 UTC]

thanks a lot, patch is in cvs

the right way to include it in the ebuild is to add it to src_unpack:

--- howl-0.9.8.ebuild   25 Feb 2005 02:17:34 -0000      1.4
+++ howl-0.9.8.ebuild   13 Mar 2005 08:35:46 -0000      1.5
@@ -16,6 +16,14 @@
 DEPEND="virtual/libc"
 # sys-devel/automake - needed if we remove the html docs from /usr/share

+src_unpack() {
+       unpack ${A}
+
+       cd ${S}
+       # patch fixes #84030 (missing linux/types.h include)
+       epatch ${FILESDIR}/${P}-types.patch
+}
+
 src_compile() {
        # The following solves compilation using linux26-headers-2.6.8.1-r2 on ia64.
        # It's not relevant for linux-headers-2.4.x or other linux26-headers, but