Bug 84004 – krusader-1.60.0_beta1.ebuild (Update)

• Product: Gentoo Linux
• Status: RESOLVED FIXED

[Description Dirk Eschler 2005-03-03 14:35:28 UTC]

Hi!

We have released Krusader 1.60.0-beta1 today. Please find attached an updated ebuild for this version. As you might have noticed, our version scheme has changed slightly, but it should be fully compatible with portage (1.60.0 is still bigger than 1.51 etc.).

The modifications to the ebuild are:
- Depends on KDE 3.3 now
- Corrected the category for two external applications in pkg_postinst() (app-misc -> kde-misc)

--
Dirk Eschler


Reproducible: Always
Steps to Reproduce:

[Comment 1 Dirk Eschler 2005-03-03 14:37:31 UTC]

Created attachment 52579 [details]
krusader-1.60.0_beta1.ebuild (Update)

[Comment 2 Jonas Bähr 2005-03-03 15:48:54 UTC]

I think we should also add an javascript-useflag to the ebuild since krusader-1.60.0 is able to use KJSEmbed (kde-base/kjsembed) if it's present at compile- (and run-) time.
is it better to call such a USE-flag 'javascript' or 'kjsembed'?

[Comment 3 Carsten Lohrke (RETIRED) 2005-03-03 15:50:52 UTC]

committed :)

[Comment 4 Carsten Lohrke (RETIRED) 2005-03-03 16:02:40 UTC]

Oh nice, bugzila did not send a collision message. The name of the flag doesn't matter Jonas, the only important thing is that the configure script doesn't try to autodetect kjsembed.

 

[Comment 5 Dirk Eschler 2005-03-03 17:18:39 UTC]

Ah yes the scripting support .. so many great new features, i have missed it completely. :)

According to http://www.gentoo.org/dyn/use-index.xml there is already a USE flag called 'javascript'. I think flags should be reused where possible and 'javascript' is quite sufficient in this case.

I have attached an updated ebuild. The latest stable kjsembed is 3.3.1, which i used as a dependency and also adjusted kdebase to 3.3.1. It works fine for me, but i'd appreciate some testing.

[Comment 6 Dirk Eschler 2005-03-03 17:20:18 UTC]

Created attachment 52589 [details]
krusader-1.60.0_beta1-r1.ebuild (Update)

[Comment 7 Carsten Lohrke (RETIRED) 2005-03-04 06:19:50 UTC]

herd: Can anyone imagine a reason for a special kjsembed use flag or is everyone fine with javascript?

[Comment 8 Gregorio Guidi (RETIRED) 2005-03-04 06:52:22 UTC]

javascript seems appropriate.

BTW, note that adding the dep means that sparc, ppc and 
amd64 kaywords should be dropped until they support kjsembed.

[Comment 9 Dirk Eschler 2005-03-05 05:58:25 UTC]

Regretfully i don't know how to proceed. It's easy to remove the keywords, but it's not a nice solution, as Krusader is supposed to work and these architectures without the javascript flag.

How is this usually handled? I can imagine something like "if use=javascript && use=amd64 then some_message". If this has been done before or there is a better way of doing it, can someone please point me to an example ebuild?

[Comment 10 Gregorio Guidi (RETIRED) 2005-03-05 07:47:06 UTC]

That was just a note for other developers, nothing to be worried about.

[Comment 11 Carsten Lohrke (RETIRED) 2005-03-05 07:48:40 UTC]

Dirk: Part of profiles are use.mask files, which would work, if we used an extra kjsembed flag. In this case, the "dirty" solution has to suffice a while:

x86? ( javascript? ( kde-base/kjsembed ) )