Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!

Bug 839198

Summary: sys-libs/glibc: automated shellcheck found errors
Product: Gentoo Linux Reporter: shellbugbot <d-shellbug>
Component: Current packagesAssignee: Gentoo Toolchain Maintainers <toolchain>
Status: RESOLVED INVALID    
Severity: normal    
Priority: Normal    
Version: unspecified   
Hardware: All   
OS: Linux   
Whiteboard:
Package list:
Runtime testing required: ---

Description shellbugbot 2022-04-18 11:06:03 UTC
Shellckeck found errors in one or more shellscripts provided by sys-libs/glibc.

Kindly refer to the findings below and the shellcheck wiki for further details:

------------------------------------------------
script: /usr/portage/sys-libs/glibc/glibc-2.31-r7.ebuild:1446

		LC_ALL=C \
		./ld-*.so --library-path . ${x} > /dev/null \
                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
error: To assign the output of a command, use var=$(cmd) . (https://github.com/koalaman/shellcheck/wiki/SC2037)

------------------------------------------------
script: /usr/portage/sys-libs/glibc/glibc-2.32-r8.ebuild:1458

		LC_ALL=C \
		./ld-*.so --library-path . ${x} > /dev/null \
                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
error: To assign the output of a command, use var=$(cmd) . (https://github.com/koalaman/shellcheck/wiki/SC2037)

------------------------------------------------
script: /usr/portage/sys-libs/glibc/glibc-2.30-r9.ebuild:1418

		LC_ALL=C \
		./ld-*.so --library-path . ${x} > /dev/null \
                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
error: To assign the output of a command, use var=$(cmd) . (https://github.com/koalaman/shellcheck/wiki/SC2037)

------------------------------------------------
script: /usr/portage/sys-libs/glibc/glibc-2.19-r2.ebuild:1262

		LC_ALL=C \
		./ld-*.so --library-path . ${x} > /dev/null \
                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
error: To assign the output of a command, use var=$(cmd) . (https://github.com/koalaman/shellcheck/wiki/SC2037)

This is an automated bug report. Conservative settings were used to minimize false-positives but there's still a chance that the above list contains non-issues.
Running shellcheck again with default settings could detect other possible issues.

References:
[1] this script: https://github.com/heeplr/gentoo-shellbug
[2] shellcheck: https://www.shellcheck.net/
Comment 1 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2022-04-19 21:34:51 UTC
I don't think this one is valid. We genuinely do want to throw away the output, it's just a sanity check to make sure the just-built glibc works.