Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!

Bug 839183

Summary: games-strategy/defcon-demo: automated shellcheck found errors
Product: Gentoo Linux Reporter: shellbugbot <d-shellbug>
Component: Current packagesAssignee: Gentoo Games <games>
Status: RESOLVED OBSOLETE    
Severity: normal Keywords: PMASKED
Priority: Normal    
Version: unspecified   
Hardware: All   
OS: Linux   
Whiteboard:
Package list:
Runtime testing required: ---
Bug Depends on: 753515    
Bug Blocks:    

Description shellbugbot 2022-04-18 11:06:02 UTC
Shellckeck found errors in one or more shellscripts provided by games-strategy/defcon-demo.

Kindly refer to the findings below and the shellcheck wiki for further details:

------------------------------------------------
script: /usr/portage/games-strategy/defcon-demo/files/defcon:2

if [ -n "GAMEDIR/lib" ] ; then
         ^^^^^^^^^^^
error: Argument to -n is always true due to literal strings. (https://github.com/koalaman/shellcheck/wiki/SC2157)

This is an automated bug report. Conservative settings were used to minimize false-positives but there's still a chance that the above list contains non-issues.
Running shellcheck again with default settings could detect other possible issues.

References:
[1] this script: https://github.com/heeplr/gentoo-shellbug
[2] shellcheck: https://www.shellcheck.net/