Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!

Bug 838844

Summary: net-ftp/pure-ftpd-1.0.50-r2 installs shell script that uses non-POSIX features
Product: Gentoo Linux Reporter: Agostino Sarubbo <ago>
Component: Current packagesAssignee: Lars Wendler (Polynomial-C) (RETIRED) <polynomial-c>
Status: RESOLVED FIXED    
Severity: normal CC: conikost
Priority: Normal    
Version: unspecified   
Hardware: All   
OS: Linux   
Whiteboard:
Package list:
Runtime testing required: ---
Bug Depends on:    
Bug Blocks: 609070    
Attachments: build.log

Description Agostino Sarubbo gentoo-dev 2022-04-16 16:28:51 UTC
https://blogs.gentoo.org/ago/2020/07/04/gentoo-tinderbox/

Issue: net-ftp/pure-ftpd-1.0.50-r2 installs shell script that uses non-POSIX features.
Discovered on: amd64 (internal ref: ci)
Comment 1 Agostino Sarubbo gentoo-dev 2022-04-16 16:28:52 UTC
CC'ing also the author of the commit (3e3e91f811c2f74ee5ef2acf2ab9333b2c9927f6)
Comment 2 Agostino Sarubbo gentoo-dev 2022-04-16 16:28:53 UTC
Created attachment 771074 [details]
build.log

build log and emerge --info
Comment 3 Lars Wendler (Polynomial-C) (RETIRED) gentoo-dev 2022-04-16 17:02:49 UTC
 * QA Notice: shell script appears to use non-POSIX feature(s):
 *    possible bashism in /etc/init.d/pure-uploadscript line 5 (${parm/?/pat[/str]}):
 *    ftpd_configfile="/etc/${SVCNAME/uploadscript/ftpd}.conf"

@Conrad: can you fix this please? Just commit it by yourself. No need to fetch my approval.
Comment 4 Lars Wendler (Polynomial-C) (RETIRED) gentoo-dev 2022-04-16 17:04:10 UTC
Oh, and this one needs a revbump of course. Just do a "git mv ..."
Comment 5 Conrad Kostecki gentoo-dev 2022-04-16 20:34:10 UTC
Ack, will do.
Comment 6 Larry the Git Cow gentoo-dev 2022-04-16 20:54:17 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=224a3cd276de4fbce8b217bd11f122db28d7136f

commit 224a3cd276de4fbce8b217bd11f122db28d7136f
Author:     Conrad Kostecki <conikost@gentoo.org>
AuthorDate: 2022-04-16 20:53:11 +0000
Commit:     Conrad Kostecki <conikost@gentoo.org>
CommitDate: 2022-04-16 20:53:11 +0000

    net-ftp/pure-ftpd: fix non-posix script
    
    Closes: https://bugs.gentoo.org/838844
    Signed-off-by: Conrad Kostecki <conikost@gentoo.org>

 .../files/{pure-uploadscript.initd => pure-uploadscript.initd-r1}       | 2 +-
 .../{pure-ftpd-1.0.50-r2.ebuild => pure-ftpd-1.0.50-r3.ebuild}          | 2 +-
 net-ftp/pure-ftpd/pure-ftpd-9999.ebuild                                 | 2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)