Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!

Bug 838715

Summary: media-sound/mac-10.20: version bump
Product: Gentoo Linux Reporter: Scott Furry <scott.wl.furry>
Component: Current packagesAssignee: Daniel Pielmeier <billie>
Status: RESOLVED FIXED    
Severity: normal CC: ionen, jstein, proxy-maint, rndxelement, sound
Priority: Normal    
Version: unspecified   
Hardware: All   
OS: Linux   
Whiteboard:
Package list:
Runtime testing required: ---
Attachments: mac-6.13.ebuild (no working - missing source downloads)
ebuild for latest release (v9.04) available upstream
ebuild - mac-10.09
Ebuild file
Log File of build failure

Description Scott Furry 2022-04-16 01:34:48 UTC
Created attachment 770951 [details]
mac-6.13.ebuild (no working - missing source downloads)

Monkey's Audio Codec
Home: https://www.monkeysaudio.com

Gentoo has available 4.11-r1 released upstream 2018Oct24
(http://gpo.zugaina.org/media-sound/mac)

Latest available upstream is 7.59 released 2022Apr12.
(https://www.monkeysaudio.com/versionhistory.html)

Upstream does not maintain historical build sources. Rolling-Release/latest only available.

Debian does make available via deb-multimedia(https://www.deb-multimedia.org/pool/main/m/monkeys-audio-dmo/). It appears org has restructured layout access to package (old available at ...pool/main/m/monkeys-audio/ while current is stored at pool/main/m/monkeys-audio-dmo/).


debain old-stable(buster): 4.11 released upstream 2018Oct24
debain stable(bullseye): 6.37 released upstream 2021Jul19
debain testing(sid): 7.59 released upstream 2022Apr12

Have a local ebuild for version 6.13 (released upstream 2021Feb24) that builds cleanly however historical zip is no longer available. Bumping revision fails as source has changed structure. Unable to resolve handling of common header files (srd_dir/Source/*.h files).

Bumping revision to at least 6.37 would seem best.

https://www.deb-multimedia.org/pool/main/m/monkeys-audio-dmo/monkeys-audio_6.37-dmo1_amd64.deb
Comment 1 Scott Furry 2022-04-16 01:38:12 UTC
* edit:
...common header files (src_dir/Source/*.h files).
Comment 2 Daniel Pielmeier gentoo-dev 2022-04-16 17:47:19 UTC
I am aware of the newer versions. I already have an ebuild locally. If you make it work with the reverse dependencies I will gladly add it to the tree.

Another option would be removing mac audio support from aqualung. Don't know if there are other consumers actually.
Comment 3 Scott Furry 2022-04-16 19:30:00 UTC
media-sound/flacon also has a dependency on media-sound/mac.
Confident there are others.

At least 6.37 to be consistent with debian stable would be useful.
Comment 4 Scott Furry 2023-01-24 17:39:01 UTC
Appreciation to pg_overlay (https://gitlab.com/Perfect_Gentleman/PG_Overlay).
Overlay had updated ebuild for version 7.60. Same ebuild can be utilized for latest version available from upstream (v 9.04)

Ebuild appears to work locally.
Comment 5 Scott Furry 2023-01-24 17:40:07 UTC
Created attachment 849151 [details]
ebuild for latest release (v9.04) available upstream
Comment 6 Daniel Pielmeier gentoo-dev 2023-01-24 18:00:41 UTC
I also have an ebuild here which works fine on it's own. However aqualung does not build against it. I did not test but I guess it is the same for flac. Looking at that ebuild it will be the same as some patching will be required or flac and aqualung upstream need to make it work with the newer versions of mac.
Comment 7 Scott Furry 2023-04-16 00:24:33 UTC
Version Bump - 10.09
Upstream changed to CMake building @9.15 release.

Ebuild attached.
Comment 8 Scott Furry 2023-04-16 00:25:33 UTC
Created attachment 860172 [details]
ebuild - mac-10.09
Comment 9 Scott Furry 2023-08-08 18:42:29 UTC
Created attachment 867443 [details]
Ebuild file

ebuild v10.17 Monkey's Audio Codec (June 29, 2023).
Same as previous attachment (v10.09).
Comment 10 Daniel Pielmeier gentoo-dev 2023-09-05 19:34:47 UTC
This is just a heads up. I am planning on bumping media-sound/mac to a recent version [1] to fix this bug. As the current version is rather ancient things might break. I already adapted media-sound/aqualung [2] to work with the newer version.

A quick search retuned the following packaged depending on media-sound/mac:
media-sound/abcde	sound@gentoo.org
media-sound/asunder	sound@gentoo.org
media-sound/dir2ogg	sound@gentoo.org
media-sound/flacon	rndxelement@protonmail.com proxy-maint@gentoo.org
media-sound/shntool	sound@gentoo.org
media-sound/xmms2	ionen@gentoo.org

Maybe it is a good idea to check the compatibility with newer versions.
I guess it will be easier if I add a masked version first.

[1] https://monkeysaudio.com/developers.html
[2] https://github.com/jeremyevans/aqualung/commit/a991c13d0df734a5d0fea7db6b181176858f3e58
Comment 11 Ionen Wolkens gentoo-dev 2023-09-05 21:21:12 UTC
Seems like this is going to need extra work.

First soname changed, but no subslot nor := are setup to trigger rebuilds with this package atm.

...but there's also the two-state thing (mac vs MAC) meaning odds are most revdeps can only build against one or the other (unless build system has some magic to detect both), so subslot rebuilds may not really be useful given can't switch back&forth.

Think simplest would be to revbump current revdeps depend on <mac-10 or so, then we can later make fixed ones that depend on the new one. Given mac is optional in all these packages (and off by default, plus kind of niche), the bounds may not come as "too" annoying until things are sorted.
Comment 12 Ionen Wolkens gentoo-dev 2023-09-05 21:24:43 UTC
(In reply to Ionen Wolkens from comment #11)
> [..] so subslot rebuilds may not really be useful
Then again it looks like it goes from so.9 to so.10, to probably so.11 with every versions. So subslot rebuilds should probably be setup anyway.
Comment 13 Ionen Wolkens gentoo-dev 2023-09-05 21:27:38 UTC
On another note, slotting the old one would also be technically possible. There is only 1 (one) file that conflicts and it's /usr/bin/mac (libraries and includes don't). Albeit this may not be worth the trouble.
Comment 14 Ionen Wolkens gentoo-dev 2023-09-05 21:57:46 UTC
(In reply to Daniel Pielmeier from comment #10)
> media-sound/xmms2	ionen@gentoo.org
All this aside, as far as I'm concern, this one does not need to be fixed. Will sooner mask the USE. Not to say slyfox (current kinda upstream, but mostly for life support) may or may not be interested.
Comment 15 Daniel Pielmeier gentoo-dev 2023-09-06 19:31:55 UTC
Hey Ionen!

Thank you very much for your feedback. I was also wondering about the proper course of action. This why I added all the maintainers of packages depending on mac.

(In reply to Ionen Wolkens from comment #11)
> Seems like this is going to need extra work.
> 
> First soname changed, but no subslot nor := are setup to trigger rebuilds
> with this package atm.
> 

Thanks, I also had subslots in mind.

> ...but there's also the two-state thing (mac vs MAC) meaning odds are most
> revdeps can only build against one or the other (unless build system has
> some magic to detect both), so subslot rebuilds may not really be useful
> given can't switch back&forth.

I was also not sure about the change in library name. At least the changes for aqualung are not backwards compatible. I was able to convince the upstream maintainer in that regard. Didn't think it was worth the trouble.

> Think simplest would be to revbump current revdeps depend on <mac-10 or so,
> then we can later make fixed ones that depend on the new one. Given mac is
> optional in all these packages (and off by default, plus kind of niche), the
> bounds may not come as "too" annoying until things are sorted.

Makes sense.

(In reply to Ionen Wolkens from comment #12)
> (In reply to Ionen Wolkens from comment #11)
> > [..] so subslot rebuilds may not really be useful
> Then again it looks like it goes from so.9 to so.10, to probably so.11 with
> every versions. So subslot rebuilds should probably be setup anyway.

Soname for the current version is 2.0.0. It will definitely change again for the newer versions. There were already a few changes in soname to get to .10.

(In reply to Ionen Wolkens from comment #13)
> On another note, slotting the old one would also be technically possible.
> There is only 1 (one) file that conflicts and it's /usr/bin/mac (libraries
> and includes don't). Albeit this may not be worth the trouble.

Agreed :-)



So what about proceeding as follows:
- revbump all reverse dependencies to depend on <media-sound/mac-4.12
- add the new version with subslot 0/10
- new versions then have to use properslot operators if they are compatible

Does this make sense or am I missing something?
Comment 16 Ionen Wolkens gentoo-dev 2023-09-06 19:51:37 UTC
(In reply to Daniel Pielmeier from comment #15)
> So what about proceeding as follows:
> - revbump all reverse dependencies to depend on <media-sound/mac-4.12
> - add the new version with subslot 0/10
> - new versions then have to use properslot operators if they are compatible
> 
> Does this make sense or am I missing something?
Haven't thought about it that much, but sounds fine to me.
Comment 17 Daniel Pielmeier gentoo-dev 2023-09-06 20:01:32 UTC
(In reply to Ionen Wolkens from comment #16)
> (In reply to Daniel Pielmeier from comment #15)
> > So what about proceeding as follows:
> > - revbump all reverse dependencies to depend on <media-sound/mac-4.12
> > - add the new version with subslot 0/10
> > - new versions then have to use properslot operators if they are compatible
> > 
> > Does this make sense or am I missing something?
> Haven't thought about it that much, but sounds fine to me.

Okay, thank you! If there are no objections/concerns, I will do this after giving everyone enough time to respond here.
Comment 18 Daniel Pielmeier gentoo-dev 2023-09-25 18:32:06 UTC
Just a final heads up. I will pin the versions of the reverse dependencies in the next few days and then bump mac.

Any reason for three stable versions of flacon? I will also remove the old versions if nobody objects. It seems all of them are affected by bug #831592.
Comment 19 Larry the Git Cow gentoo-dev 2023-09-30 11:36:27 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=aaa5c0b0817987165cb156a4c13f9a42546b4bab

commit aaa5c0b0817987165cb156a4c13f9a42546b4bab
Author:     Daniel Pielmeier <billie@gentoo.org>
AuthorDate: 2023-09-30 11:30:43 +0000
Commit:     Daniel Pielmeier <billie@gentoo.org>
CommitDate: 2023-09-30 11:35:14 +0000

    media-sound/*: Prepare for media-sound/mac bump
    
    Bug: https://bugs.gentoo.org/838715
    Signed-off-by: Daniel Pielmeier <billie@gentoo.org>

 .../{abcde-2.9.3-r3.ebuild => abcde-2.9.3-r4.ebuild}      |  4 ++--
 .../{aqualung-1.2-r1.ebuild => aqualung-1.2-r2.ebuild}    | 15 ++++++++++-----
 .../{asunder-2.9.7.ebuild => asunder-2.9.7-r1.ebuild}     |  4 ++--
 .../{asunder-3.0.1.ebuild => asunder-3.0.1-r1.ebuild}     |  2 +-
 .../{dir2ogg-0.13-r1.ebuild => dir2ogg-0.13-r2.ebuild}    |  2 +-
 .../{flacon-10.0.0.ebuild => flacon-10.0.0-r1.ebuild}     |  2 +-
 ...{shntool-3.0.10-r2.ebuild => shntool-3.0.10-r3.ebuild} |  4 ++--
 .../xmms2/{xmms2-0.9.3.ebuild => xmms2-0.9.3-r1.ebuild}   |  2 +-
 8 files changed, 20 insertions(+), 15 deletions(-)
Comment 21 Scott Furry 2023-09-30 15:22:30 UTC
Build Failure during patching of sources. Log file attached
Comment 22 Scott Furry 2023-09-30 15:23:30 UTC
Created attachment 871836 [details]
Log File of build failure

Emerge Log File of build failure.
Comment 23 Daniel Pielmeier gentoo-dev 2023-09-30 16:10:41 UTC
(In reply to Scott Furry from comment #21)
> Build Failure during patching of sources. Log file attached

Build failure due to missing patches which I forgot to add! :-)

Try again a bit later!