Bug 83861

Summary:	Easytag 1.99.3: hard-coded path to freedb.org
Product:	Gentoo Linux	Reporter:	Dieter Verfaillie <dieterv>
Component:	Current packages	Assignee:	Gentoo Sound Team <sound>
Status:	RESOLVED INVALID
Severity:	normal
Priority:	High
Version:	unspecified
Hardware:	All
OS:	Linux
Whiteboard:
Package list:		Runtime testing required:	---
Attachments:	patch cddb.c correct patch

Description Dieter Verfaillie 2005-03-02 11:47:54 UTC

Hi there,

Easytag 1.99.3 (and .2, didn't bother to look further) contains hardcoded paths to freedb.org instead of using the path entered in the preferences window. This doesn't work well with a local install of cddb and no internet connection...

Included patch fixes 2 of them.
I didn't know what to do with the rest (ie http://www.freedb.org/freedb_search.php on line 1820) as that doesn't work on a local cddb install (where can i find those php files???)

Reproducible: Always
Steps to Reproduce:
1. emerge easytag-1.99.3
2. get a local freedb install
3. change easytag cddb preferences
3. disconnect from internet (laptop)
4. use the cddb feature
Actual Results:  
tries to connecto to freedb.org

Expected Results:  
should have connected to cddb server specified in the preferences window

Comment 1 Dieter Verfaillie 2005-03-02 11:48:24 UTC

Created attachment 52481 [details, diff]
patch cddb.c

Comment 2 Dieter Verfaillie 2005-03-02 11:54:41 UTC

Created attachment 52482 [details, diff]
correct patch

discard 52481, this is the one... sorry...

Comment 3 Dieter Verfaillie 2005-03-02 12:23:45 UTC

just found out the hard way:
  -automatic search uses cddb.cgi and the freedb settings from preferences
  -manual search uses http://www.freedb.org/freedb_search.php
so, no need to patch anything...

sorry