Bug 838460

Summary:	x11-drivers/xf86-input-libinput-1.2.1 calls eend without preceding ebegin
Product:	Gentoo Linux	Reporter:	Agostino Sarubbo <ago>
Component:	Current packages	Assignee:	Gentoo X packagers <x11>
Status:	RESOLVED FIXED
Severity:	normal
Priority:	Normal
Version:	unspecified
Hardware:	All
OS:	Linux
Whiteboard:
Package list:		Runtime testing required:	---
Attachments:	build.log

Description Agostino Sarubbo gentoo-dev

2022-04-15 12:23:59 UTC

https://blogs.gentoo.org/ago/2020/07/04/gentoo-tinderbox/

Issue: x11-drivers/xf86-input-libinput-1.2.1 calls eend without preceding ebegin.
Discovered on: amd64 (internal ref: ci)

Comment 1 Agostino Sarubbo gentoo-dev

2022-04-15 12:24:01 UTC

Created attachment 770870 [details]
build.log

build log and emerge --info

Comment 2 Mike Gilbert gentoo-dev

2022-04-15 13:58:01 UTC

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=47803df5816c7a1bead7bf4b606a1cfa4dd094e5

commit 47803df5816c7a1bead7bf4b606a1cfa4dd094e5
Author:     Thomas Bracht Laumann Jespersen <t@laumann.xyz>
AuthorDate: Wed Apr 13 11:03:14 2022 +0200
Commit:     Mike Pagano <mpagano@gentoo.org>
CommitDate: Fri Apr 15 08:11:05 2022 -0400

    linux-info.eclass: Call ebegin, properly close with eend

    A recent QA check added to portage informs of eend being called without
    a preceding call to ebegin.

    This warning was emitted during pkg_setup for net-vpn/openvpn, and was
    traced back to the check_extra_config() function in linux-info.eclass.

    The preference is here to call ebegin (instead of dropping the lone
    eend) and in each of the possible exit branches for check_extra_config()
    call eend appropriately.

    Reported-by: Sam James <sam@gentoo.org>
    Signed-off-by: Thomas Bracht Laumann Jespersen <t@laumann.xyz>
    Closes: https://github.com/gentoo/gentoo/pull/25019
    Signed-off-by: Mike Pagano <mpagano@gentoo.org>

 eclass/linux-info.eclass | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)