Bug 837794

Summary:	sys-block/gparted-1.4.0 fails to compile: BCache_Info.cc:52:40: error: basename was not declared in this scope; did you mean g_basename?
Product:	Gentoo Linux	Reporter:	Agostino Sarubbo <ago>
Component:	Current packages	Assignee:	Gentoo Linux Gnome Desktop Team <gnome>
Status:	RESOLVED FIXED
Severity:	normal	CC:	sam
Priority:	Normal	Keywords:	PATCH
Version:	unspecified
Hardware:	All
OS:	Linux
See Also:	https://bugs.gentoo.org/show_bug.cgi?id=848420
Whiteboard:
Package list:		Runtime testing required:	---
Attachments:	build.log Upstream patch for sys-block/gparted-1.4.0 Patch for sys-block/gparted-1.4.0.ebuild

Description Agostino Sarubbo gentoo-dev

2022-04-11 07:00:26 UTC

https://blogs.gentoo.org/ago/2020/07/04/gentoo-tinderbox/

Issue: sys-block/gparted-1.4.0 fails to compile.
Discovered on: amd64 (internal ref: tinderbox_musl)

NOTE:
This machine uses MUSL libc

Comment 1 Agostino Sarubbo gentoo-dev

2022-04-11 07:00:28 UTC

Created attachment 770021 [details]
build.log

build log and emerge --info

Comment 2 CFuga 2022-05-18 20:35:27 UTC

Created attachment 779450 [details, diff]
Upstream patch for sys-block/gparted-1.4.0

Upstream has a fix for this bug. I've attached the patch, available from

https://gitlab.gnome.org/GNOME/gparted/-/merge_requests/99

Comment 3 CFuga 2022-05-18 20:37:02 UTC

Created attachment 779453 [details, diff]
Patch for sys-block/gparted-1.4.0.ebuild

Patch for sys-block/gparted-1.4.0.ebuild, to apply the upstream fix for this bug.

Comment 4 Sam James archtester

2022-05-18 20:37:31 UTC

(In reply to CFuga from comment #2)
> Created attachment 779450 [details, diff] [details, diff]
> Upstream patch for sys-block/gparted-1.4.0
> 
> Upstream has a fix for this bug. I've attached the patch, available from
> 
> https://gitlab.gnome.org/GNOME/gparted/-/merge_requests/99

Thanks!

Comment 5 Larry the Git Cow gentoo-dev

2022-05-18 20:38:33 UTC

The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=1a536e7e575df3fb58dd7d6cf56ec0809718a796

commit 1a536e7e575df3fb58dd7d6cf56ec0809718a796
Author:     Sam James <sam@gentoo.org>
AuthorDate: 2022-05-18 20:37:37 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2022-05-18 20:37:37 +0000

    sys-block/gparted: fix build with musl
    
    Revbump as switching to POSIX basename could in theory (but as per
    patch, shouldn't) change runtime behaviour for glibc.
    
    Closes: https://bugs.gentoo.org/837794
    Signed-off-by: Sam James <sam@gentoo.org>

 .../files/gparted-1.4.0-musl-basename.patch        | 53 ++++++++++++
 sys-block/gparted/gparted-1.4.0-r1.ebuild          | 95 ++++++++++++++++++++++
 2 files changed, 148 insertions(+)