Bug 837188 – app-portage/portage-utils: qcheck: 98 out of 81 files are good

• Product: Gentoo Linux
• Status: RESOLVED FIXED

[Description Jonas Stein 2022-04-07 22:15:17 UTC]

# qcheck app-admin/sudo
Checking app-admin/sudo ...
 MD5-DIGEST: /etc/sudoers
  * 80 out of 81 files are good

# qcheck app-admin/sudo --skip-protected
Checking app-admin/sudo ...
 MD5-DIGEST: /etc/sudoers
  * 98 out of 81 files are good


"98 out of 81 files are good" is impossible/makes no sense.

[Comment 1 Sam James 2022-04-07 22:19:16 UTC]

qcheck is provided by portage-utils.

[Comment 2 Fabian Groffen 2022-04-08 06:46:40 UTC]

I would agree that this does not look plausible.

[Comment 3 Larry the Git Cow 2022-04-09 11:32:52 UTC]

The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/proj/portage-utils.git/commit/?id=ede72d3cf08df8ffe7e59c4819d9a6c84ab1659f

commit ede72d3cf08df8ffe7e59c4819d9a6c84ab1659f
Author:     Fabian Groffen <[e-mail]>
AuthorDate: 2022-04-09 11:17:39 +0000
Commit:     Fabian Groffen <[e-mail]>
CommitDate: 2022-04-09 11:32:30 +0000

    qcheck: fix config-protect check, bug #837188
    
    ensure we break out of the config-protect directories loop, instead of
    just skipping one directory, such that we don't produce bogus amounts of
    files, and also don't check despite we were told not to check (-P)
    
    Bug: https://bugs.gentoo.org/837188
    Signed-off-by: Fabian Groffen <[e-mail]>

 qcheck.c                 | 253 ++++++++++++++++++++++++++++-------------------
 tests/qcheck/list05.good |   2 +-
 tests/qcheck/list07.good |   2 +-
 3 files changed, 156 insertions(+), 101 deletions(-)

[Comment 4 Larry the Git Cow 2022-06-14 07:15:56 UTC]

The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=ec3307e507ccfc092371f8e16ea40ff50557ca9f

commit ec3307e507ccfc092371f8e16ea40ff50557ca9f
Author:     Fabian Groffen <[e-mail]>
AuthorDate: 2022-06-14 07:12:19 +0000
Commit:     Fabian Groffen <[e-mail]>
CommitDate: 2022-06-14 07:15:51 +0000

    app-portage/portage-utils-0.94: version bump
    
    Closes: https://bugs.gentoo.org/851138
    Closes: https://bugs.gentoo.org/837188
    Closes: https://bugs.gentoo.org/836590
    Closes: https://bugs.gentoo.org/833942
    Closes: https://bugs.gentoo.org/807975
    Signed-off-by: Fabian Groffen <[e-mail]>

 app-portage/portage-utils/Manifest                 |  1 +
 .../portage-utils/portage-utils-0.94.ebuild        | 67 ++++++++++++++++++++++
 2 files changed, 68 insertions(+)