Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!

Bug 836690

Summary: sys-block/tgt-1.0.87 installs shell script that uses non-POSIX features
Product: Gentoo Linux Reporter: Agostino Sarubbo <ago>
Component: Current packagesAssignee: Matthew Thode ( prometheanfire ) <prometheanfire>
Status: RESOLVED FIXED    
Severity: normal CC: cluster, forza
Priority: Normal    
Version: unspecified   
Hardware: All   
OS: Linux   
Whiteboard:
Package list:
Runtime testing required: ---
Bug Depends on:    
Bug Blocks: 609070    
Attachments: build.log

Description Agostino Sarubbo gentoo-dev 2022-04-03 10:10:53 UTC
https://blogs.gentoo.org/ago/2020/07/04/gentoo-tinderbox/

Issue: sys-block/tgt-1.0.82 installs shell script that uses non-POSIX features.
Discovered on: amd64 (internal ref: ci)
Comment 1 Agostino Sarubbo gentoo-dev 2022-04-03 10:10:55 UTC
Created attachment 768571 [details]
build.log

build log and emerge --info
Comment 2 Agostino Sarubbo gentoo-dev 2022-06-05 07:03:33 UTC
ci has reproduced this issue with version 1.0.83 - Updating summary.
Comment 3 Agostino Sarubbo gentoo-dev 2022-08-07 05:37:04 UTC
ci has reproduced this issue with version 1.0.84 - Updating summary.
Comment 4 Agostino Sarubbo gentoo-dev 2023-01-01 19:02:56 UTC
ci has reproduced this issue with version 1.0.85 - Updating summary.
Comment 5 Agostino Sarubbo gentoo-dev 2023-02-01 21:06:01 UTC
ci has reproduced this issue with version 1.0.86 - Updating summary.
Comment 6 Agostino Sarubbo gentoo-dev 2023-08-03 06:10:10 UTC
ci has reproduced this issue with version 1.0.87 - Updating summary.
Comment 7 Forza 2023-08-14 21:05:48 UTC
I submitted new init scripts at https://bugs.gentoo.org/911680 

Not sure they are 100% POSIX, but they pass shellcheck.
Comment 8 Larry the Git Cow gentoo-dev 2023-08-15 18:53:57 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=3a5c6ac8c88119c492a4a4dadcfce9aceb44b9a5

commit 3a5c6ac8c88119c492a4a4dadcfce9aceb44b9a5
Author:     Matthew Thode <prometheanfire@gentoo.org>
AuthorDate: 2023-08-15 18:53:02 +0000
Commit:     Matthew Thode <prometheanfire@gentoo.org>
CommitDate: 2023-08-15 18:53:02 +0000

    sys-block/tgt: make init scripts posix compliant
    
    Thanks to Forza-tng for the new scripts
    
    Closes: https://bugs.gentoo.org/911680
    Closes: https://bugs.gentoo.org/836690
    
    Signed-off-by: Matthew Thode <prometheanfire@gentoo.org>

 sys-block/tgt/files/tgtd.confd-new |   7 ++
 sys-block/tgt/files/tgtd.initd-new | 136 +++++++++++++++++++++++++++++++++++++
 sys-block/tgt/tgt-1.0.87-r1.ebuild |  61 +++++++++++++++++
 3 files changed, 204 insertions(+)