Bug 836614

Summary:	sys-cluster/k3s-1.23.5_p1 installs shell script that uses non-POSIX features
Product:	Gentoo Linux	Reporter:	Agostino Sarubbo <ago>
Component:	Current packages	Assignee:	Zac Medico <zmedico>
Status:	RESOLVED FIXED
Severity:	normal
Priority:	Normal
Version:	unspecified
Hardware:	All
OS:	Linux
Whiteboard:
Package list:		Runtime testing required:	---
Bug Depends on:
Bug Blocks:	609070
Attachments:	build.log.xz

Description Agostino Sarubbo gentoo-dev

2022-04-01 19:40:27 UTC

https://blogs.gentoo.org/ago/2020/07/04/gentoo-tinderbox/

Issue: sys-cluster/k3s-1.23.5_p1 installs shell script that uses non-POSIX features.
Discovered on: amd64 (internal ref: ci)

Comment 1 Agostino Sarubbo gentoo-dev

2022-04-01 19:40:32 UTC

Created attachment 768444 [details]
build.log.xz

build log and emerge --info (compressed because it exceeds attachment limit, use 'xzless' to read it)

Comment 2 Zac Medico gentoo-dev

2022-04-01 23:49:20 UTC

 * QA Notice: shell script appears to use non-POSIX feature(s):
 *    possible bashism in /etc/init.d/k3s line 30 (should be '.', not 'source'):
 *    if [ -f /etc/environment ]; then source /etc/environment; fi
 *    possible bashism in /etc/init.d/k3s line 31 (should be '.', not 'source'):
 *    if [ -f /etc/rancher/k3s/k3s.env ]; then source /etc/rancher/k3s/k3s.env; fi

Comment 3 Larry the Git Cow gentoo-dev

2022-04-03 17:26:11 UTC

The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=df0333a02c6363b79e61c79af858c5f58dd7e465

commit df0333a02c6363b79e61c79af858c5f58dd7e465
Author:     Zac Medico <zmedico@gentoo.org>
AuthorDate: 2022-04-03 17:21:34 +0000
Commit:     Zac Medico <zmedico@gentoo.org>
CommitDate: 2022-04-03 17:26:07 +0000

    sys-cluster/k3s: fix init script bashisms
    
    Closes: https://bugs.gentoo.org/836614
    Signed-off-by: Zac Medico <zmedico@gentoo.org>

 sys-cluster/k3s/files/k3s.initd | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)