Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!

Bug 836587

Summary: www-client/firefox should support llvm-14
Product: Gentoo Linux Reporter: marios4
Component: Current packagesAssignee: Mozilla Gentoo Team <mozilla>
Status: RESOLVED FIXED    
Severity: normal CC: Adrian.Bassett, ao, gentoobugs, gyakovlev, jstein, lo48576, rust
Priority: Normal    
Version: unspecified   
Hardware: All   
OS: Linux   
Whiteboard:
Package list:
Runtime testing required: ---

Description marios4 2022-04-01 11:23:13 UTC
firefox has LLVM_MAX_SLOT=13 while llvm 14 has been released.
Comment 1 Joonas Niilola gentoo-dev 2022-04-02 13:16:17 UTC
It's pretty much impossible before rust{-bin} supports llvm-14. Firefox will bump the compatibility after rust gets the support.
Comment 2 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2022-04-02 13:47:34 UTC
(In reply to Joonas Niilola from comment #1)
> It's pretty much impossible before rust{-bin} supports llvm-14. Firefox will
> bump the compatibility after rust gets the support.

I do wonder if this really matters as it only affects the unsupported and non-default USE=system-llvm (and for non-bin only).
Comment 3 Joonas Niilola gentoo-dev 2022-04-02 17:27:04 UTC
(In reply to Sam James from comment #2)
> 
> I do wonder if this really matters as it only affects the unsupported and
> non-default USE=system-llvm (and for non-bin only).

Well, yes.
https://gitweb.gentoo.org/repo/gentoo.git/tree/www-client/firefox/firefox-98.0.2.ebuild#n451
(in short: there's a breakage for rust-llvm-lld chain when you start mixing the versions, what's compiled with what)

and while you could say this doesn't apply for everyone, I feel much more at ease stopping the build breaks for those it does. And this is a rather easy local-mod for those wishing to depclean llvm:13, 
edit LLVM_MAX_SLOT=13 -> "=14" and add this to your BDEPEND block:
|| (
	(
		sys-devel/clang:14
		sys-devel/llvm:14
		clang? (
			=sys-devel/lld-14*
			pgo? ( =sys-libs/compiler-rt-sanitizers-14*[profile] )
		)
	)
...
...
...
)
Comment 4 cyrillic 2022-04-07 13:05:43 UTC
For what it is worth, I have already been compiling rust/spidermonkey/firefox with llvm/clang/lld-14 for a while now, and it seems to work ok.
Comment 5 Pavel Volkov 2022-04-09 10:25:51 UTC
It seems rust 1.60 is out, which uses LLVM 14.
Comment 6 Larry the Git Cow gentoo-dev 2022-04-09 15:25:56 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=fd5635e0c7269edb0261a35ff9e779cfc26288e9

commit fd5635e0c7269edb0261a35ff9e779cfc26288e9
Author:     Joonas Niilola <juippis@gentoo.org>
AuthorDate: 2022-04-09 15:25:02 +0000
Commit:     Joonas Niilola <juippis@gentoo.org>
CommitDate: 2022-04-09 15:25:02 +0000

    www-client/firefox: enable llvm:14 for 99.0
    
    Bug: https://bugs.gentoo.org/836587
    Bug: https://bugs.gentoo.org/837122
    Signed-off-by: Joonas Niilola <juippis@gentoo.org>

 www-client/firefox/firefox-99.0.ebuild | 10 +++++++++-
 1 file changed, 9 insertions(+), 1 deletion(-)
Comment 7 Joonas Niilola gentoo-dev 2022-04-09 15:30:47 UTC
I'll continue testing firefox:esr, thunderbird and spidermonkey:91 tomorrow. Firefox-99.0 was the most important target for now.
Comment 8 Larry the Git Cow gentoo-dev 2022-04-10 16:32:59 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=484fc31e5a267dcb5ee1dc2cb53c4adebd47e1c1

commit 484fc31e5a267dcb5ee1dc2cb53c4adebd47e1c1
Author:     Joonas Niilola <juippis@gentoo.org>
AuthorDate: 2022-04-10 16:30:08 +0000
Commit:     Joonas Niilola <juippis@gentoo.org>
CommitDate: 2022-04-10 16:32:57 +0000

    dev-lang/spidermonkey: enable llvm:14 on 91.8.0
    
    Closes: https://bugs.gentoo.org/836587
    Signed-off-by: Joonas Niilola <juippis@gentoo.org>

 dev-lang/spidermonkey/spidermonkey-91.8.0.ebuild | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

Additionally, it has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=bebe34cb50312d49f0f39da27c3d72433ed55226

commit bebe34cb50312d49f0f39da27c3d72433ed55226
Author:     Joonas Niilola <juippis@gentoo.org>
AuthorDate: 2022-04-10 16:29:21 +0000
Commit:     Joonas Niilola <juippis@gentoo.org>
CommitDate: 2022-04-10 16:32:57 +0000

    mail-client/thunderbird: enable llvm:14 on 91.8.0
    
    Bug: https://bugs.gentoo.org/836587
    Signed-off-by: Joonas Niilola <juippis@gentoo.org>

 mail-client/thunderbird/thunderbird-91.8.0.ebuild | 10 +++++++++-
 1 file changed, 9 insertions(+), 1 deletion(-)

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=2fd5f7c4a9ef9f6efaf7aca81c0049b15cb86d42

commit 2fd5f7c4a9ef9f6efaf7aca81c0049b15cb86d42
Author:     Joonas Niilola <juippis@gentoo.org>
AuthorDate: 2022-04-10 16:28:12 +0000
Commit:     Joonas Niilola <juippis@gentoo.org>
CommitDate: 2022-04-10 16:32:57 +0000

    www-client/firefox: enable llvm:14 for 91.8.0
    
    Bug: https://bugs.gentoo.org/836587
    Signed-off-by: Joonas Niilola <juippis@gentoo.org>

 www-client/firefox/firefox-91.8.0.ebuild | 11 ++++++++++-
 1 file changed, 10 insertions(+), 1 deletion(-)