Bug 836317 – x11-libs/pango-1.50.6 fails test - tests failed

• Product: Gentoo Linux
• Status: RESOLVED FIXED

[Description Toralf Förster 2022-03-28 09:00:34 UTC]

Timeout:            0   

Full log written to /var/tmp/portage/x11-libs/pango-1.50.6/work/pango-1.50.6-abi_x86_64.amd64/meson-logs/testlog.txt
 * ERROR: x11-libs/pango-1.50.6::gentoo failed (test phase):
 *   tests failed
 * 
 * Call stack:

  -------------------------------------------------------------------

  This is an unstable amd64 chroot image at a tinderbox (==build bot)
  name: 17.1_desktop_gnome_systemd-j4_test-20220327-230019

  -------------------------------------------------------------------

gcc-config -l:
 [1] x86_64-pc-linux-gnu-11.2.1 *
clang/llvm (if any):
/usr/lib/llvm/14
14.0.0
Python 3.9.9
Available Rust versions:
  [1]   rust-1.59.0 *
php cli:

  HEAD of ::gentoo
commit cd569d7a5f408b824c63e58874c90cf321009f1c
Author: Repository mirror & CI <[e-mail]>
Date:   Mon Mar 28 05:49:48 2022 +0000

    2022-03-28 05:49:46 UTC

emerge -qpvO x11-libs/pango
[ebuild  N    ] x11-libs/pango-1.50.6  USE="X introspection sysprof -debug" ABI_X86="(64) -32 (-x32)"

[Comment 1 Toralf Förster 2022-03-28 09:00:35 UTC]

Created attachment 768066 [details]
emerge-info.txt

[Comment 2 Toralf Förster 2022-03-28 09:00:36 UTC]

Created attachment 768067 [details]
emerge-history.txt

[Comment 3 Toralf Förster 2022-03-28 09:00:38 UTC]

Created attachment 768068 [details]
environment

[Comment 4 Toralf Förster 2022-03-28 09:00:42 UTC]

Created attachment 768069 [details]
etc.portage.tar.bz2

[Comment 5 Toralf Förster 2022-03-28 09:00:43 UTC]

Created attachment 768070 [details]
logs.tar.bz2

[Comment 6 Toralf Förster 2022-03-28 09:00:44 UTC]

Created attachment 768071 [details]
temp.tar.bz2

[Comment 7 Toralf Förster 2022-03-28 09:00:46 UTC]

Created attachment 768072 [details]
tests.tar.bz2

[Comment 8 Toralf Förster 2022-03-28 09:00:47 UTC]

Created attachment 768073 [details]
x11-libs:pango-1.50.6:20220328-062137.log.bz2

[Comment 9 Sam James 2022-06-05 07:07:17 UTC]

*** Bug 839816 has been marked as a duplicate of this bug. ***

[Comment 10 WANG Xuerui 2022-06-07 02:49:17 UTC]

*** Bug 843383 has been marked as a duplicate of this bug. ***

[Comment 11 Sam James 2022-06-14 15:20:51 UTC]

Might well be fixed by https://gitlab.gnome.org/GNOME/pango/-/commit/0226bdd9c223f5651b6657a14cebc900bbac4b19.

[Comment 12 Paolo Pedroni 2022-06-15 10:14:46 UTC]

(In reply to Sam James from comment #11)
> Might well be fixed by
> https://gitlab.gnome.org/GNOME/pango/-/commit/
> 0226bdd9c223f5651b6657a14cebc900bbac4b19.

That fixes it. Can we backport it?

[Comment 13 Paolo Pedroni 2022-06-15 11:23:48 UTC]

(In reply to Paolo Pedroni from comment #12)
> (In reply to Sam James from comment #11)
> > Might well be fixed by
> > https://gitlab.gnome.org/GNOME/pango/-/commit/
> > 0226bdd9c223f5651b6657a14cebc900bbac4b19.
> 
> That fixes it. Can we backport it?

Still failing with ABI_X86=32 on a multilib box (works with ABI_X86=64).

[Comment 14 Larry the Git Cow 2022-06-16 23:19:36 UTC]

The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=f738d92e64131be574522fb862077ea595f9eda4

commit f738d92e64131be574522fb862077ea595f9eda4
Author:     Sam James <[e-mail]>
AuthorDate: 2022-06-16 23:19:27 +0000
Commit:     Sam James <[e-mail]>
CommitDate: 2022-06-16 23:19:27 +0000

    x11-libs/pango: fix tests w/ Harfbuzz 4.0.0
    
    Bug: https://bugs.gentoo.org/836317
    Signed-off-by: Sam James <[e-mail]>

 x11-libs/pango/files/1.50.7-harfbuzz-4.patch | 78 ++++++++++++++++++++++++++++
 x11-libs/pango/pango-1.50.7.ebuild           |  4 ++
 2 files changed, 82 insertions(+)

[Comment 15 Sam James 2022-06-16 23:19:43 UTC]

(In reply to Paolo Pedroni from comment #13)
> (In reply to Paolo Pedroni from comment #12)
> > (In reply to Sam James from comment #11)
> > > Might well be fixed by
> > > https://gitlab.gnome.org/GNOME/pango/-/commit/
> > > 0226bdd9c223f5651b6657a14cebc900bbac4b19.
> > 
> > That fixes it. Can we backport it?
> 
> Still failing with ABI_X86=32 on a multilib box (works with ABI_X86=64).

Could you report that failure upstream w/ the patch applied then?

[Comment 16 Matt Turner 2022-06-17 02:25:45 UTC]

(In reply to Paolo Pedroni from comment #13)
> (In reply to Paolo Pedroni from comment #12)
> > (In reply to Sam James from comment #11)
> > > Might well be fixed by
> > > https://gitlab.gnome.org/GNOME/pango/-/commit/
> > > 0226bdd9c223f5651b6657a14cebc900bbac4b19.
> > 
> > That fixes it. Can we backport it?
> 
> Still failing with ABI_X86=32 on a multilib box (works with ABI_X86=64).

You shouldn't ever expect these tests to pass on 32-bit x86. Floating-point rounding happens with different (greater, actually) precision. The tests are far too strict for the real world with optimizing compilers, etc. This is the first time I've seen them pass on amd64. 32-bit x86 is not a realistic goal.

If anything, we should disable those tests on x86.

[Comment 17 Paolo Pedroni 2022-06-17 10:04:09 UTC]

(In reply to Matt Turner from comment #16)
> You shouldn't ever expect these tests to pass on 32-bit x86. Floating-point
> rounding happens with different (greater, actually) precision. The tests are
> far too strict for the real world with optimizing compilers, etc. This is
> the first time I've seen them pass on amd64. 32-bit x86 is not a realistic
> goal.
> 
> If anything, we should disable those tests on x86.

Can't we just disable test-layout test?

[Comment 18 Matt Turner 2022-06-17 13:29:45 UTC]

(In reply to Paolo Pedroni from comment #17)
> (In reply to Matt Turner from comment #16)
> > You shouldn't ever expect these tests to pass on 32-bit x86. Floating-point
> > rounding happens with different (greater, actually) precision. The tests are
> > far too strict for the real world with optimizing compilers, etc. This is
> > the first time I've seen them pass on amd64. 32-bit x86 is not a realistic
> > goal.
> > 
> > If anything, we should disable those tests on x86.
> 
> Can't we just disable test-layout test?

That's what I'm saying, yes.

[Comment 19 Larry the Git Cow 2022-07-04 19:55:32 UTC]

The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=32a88d9b998dbb1dc950a8e109bb621b96c5fb6b

commit 32a88d9b998dbb1dc950a8e109bb621b96c5fb6b
Author:     Matt Turner <[e-mail]>
AuthorDate: 2022-07-04 19:44:37 +0000
Commit:     Matt Turner <[e-mail]>
CommitDate: 2022-07-04 19:55:24 +0000

    x11-libs/pango: Version bump to 1.50.8
    
    Bug: https://bugs.gentoo.org/836317
    Signed-off-by: Matt Turner <[e-mail]>

 x11-libs/pango/Manifest                      |  1 +
 x11-libs/pango/files/1.50.8-harfbuzz-4.patch | 47 ++++++++++++++
 x11-libs/pango/pango-1.50.8.ebuild           | 91 ++++++++++++++++++++++++++++
 3 files changed, 139 insertions(+)

[Comment 20 Matt Turner 2022-07-04 19:56:31 UTC]

(In reply to Matt Turner from comment #18)
> (In reply to Paolo Pedroni from comment #17)
> > (In reply to Matt Turner from comment #16)
> > > You shouldn't ever expect these tests to pass on 32-bit x86. Floating-point
> > > rounding happens with different (greater, actually) precision. The tests are
> > > far too strict for the real world with optimizing compilers, etc. This is
> > > the first time I've seen them pass on amd64. 32-bit x86 is not a realistic
> > > goal.
> > > 
> > > If anything, we should disable those tests on x86.
> > 
> > Can't we just disable test-layout test?
> 
> That's what I'm saying, yes.

I don't know how to disable the test just on x86 in the ebuild.

Suggestions welcome.

[Comment 21 Larry the Git Cow 2023-02-20 17:43:55 UTC]

The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=f4b73fb4880e3fc87644893a6bce43621a0c8c41

commit f4b73fb4880e3fc87644893a6bce43621a0c8c41
Author:     Matt Turner <[e-mail]>
AuthorDate: 2023-02-20 17:36:13 +0000
Commit:     Matt Turner <[e-mail]>
CommitDate: 2023-02-20 17:42:28 +0000

    x11-libs/pango: Version bump to 1.50.13
    
    Closes: https://bugs.gentoo.org/788463
    Closes: https://bugs.gentoo.org/836317
    Signed-off-by: Matt Turner <[e-mail]>

 x11-libs/pango/Manifest             |  1 +
 x11-libs/pango/pango-1.50.13.ebuild | 87 +++++++++++++++++++++++++++++++++++++
 2 files changed, 88 insertions(+)