Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!

Bug 836248

Summary: sci-libs/rocFFT-5.0.2 fails to compile: client_utils.h:29:10: fatal error: omp.h file not found
Product: Gentoo Linux Reporter: Agostino Sarubbo <ago>
Component: Current packagesAssignee: Gentoo Science Related Packages <sci>
Status: RESOLVED FIXED    
Severity: normal CC: candrews, gentoo, heroxbd, xgreenlandforwyy
Priority: Normal Keywords: PullRequest
Version: unspecified   
Hardware: All   
OS: Linux   
See Also: https://github.com/gentoo/gentoo/pull/26286
Whiteboard:
Package list:
Runtime testing required: ---
Attachments: build.log

Description Agostino Sarubbo gentoo-dev 2022-03-27 06:19:38 UTC
https://blogs.gentoo.org/ago/2020/07/04/gentoo-tinderbox/

Issue: sci-libs/rocFFT-5.0.2 fails to compile.
Discovered on: amd64 (internal ref: ci)
Comment 1 Agostino Sarubbo gentoo-dev 2022-03-27 06:19:40 UTC
CC'ing also the author of the commit (83c4bf0776b5e64867f547284ca794254dab36f7)
Comment 2 Agostino Sarubbo gentoo-dev 2022-03-27 06:19:42 UTC
Created attachment 767945 [details]
build.log

build log and emerge --info
Comment 3 Agostino Sarubbo gentoo-dev 2022-03-27 06:19:43 UTC
Error(s) that match a know pattern in addition to what has been reported in the summary:


FAILED: clients/tests/CMakeFiles/rocfft-test.dir/accuracy_test_1D.cpp.o 
FAILED: clients/tests/CMakeFiles/rocfft-test.dir/accuracy_test_2D.cpp.o 
FAILED: clients/tests/CMakeFiles/rocfft-test.dir/accuracy_test_3D.cpp.o 
FAILED: clients/tests/CMakeFiles/rocfft-test.dir/accuracy_test_adhoc.cpp.o 
FAILED: clients/tests/CMakeFiles/rocfft-test.dir/accuracy_test_callback.cpp.o 
FAILED: clients/tests/CMakeFiles/rocfft-test.dir/accuracy_test.cpp.o 
FAILED: clients/tests/CMakeFiles/rocfft-test.dir/gtest_main.cpp.o 
FAILED: clients/tests/CMakeFiles/rocfft-test.dir/hermitian_test.cpp.o 
FAILED: clients/tests/CMakeFiles/rocfft-test.dir/multithread_test.cpp.o 
/var/tmp/portage/sci-libs/rocFFT-5.0.2/work/rocFFT-rocm-5.0.2/clients/tests/../client_utils.h:29:10: fatal error: 'omp.h' file not found
Comment 4 Benda Xu gentoo-dev 2022-03-27 09:17:11 UTC
Looks like a missing dependency again.
Comment 5 Yiyang Wu 2022-03-27 09:44:14 UTC
(In reply to Benda Xu from comment #4)
> Looks like a missing dependency again.

Since ROCm use a patched llvm suite, I guess we need to turn on "openmp" project in sys-devel/llvm-roc.

However I'm curious why there is no bug report from tinderbox for rocFFFT-4.3.0, which ought to have the same issue.
Comment 6 Larry the Git Cow gentoo-dev 2022-07-09 06:10:00 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=b1c006b62dadab22d2e0944a68e664a7210e0ac1

commit b1c006b62dadab22d2e0944a68e664a7210e0ac1
Author:     Yiyang Wu <xgreenlandforwyy@gmail.com>
AuthorDate: 2022-07-08 15:17:11 +0000
Commit:     Benda Xu <heroxbd@gentoo.org>
CommitDate: 2022-07-09 06:09:49 +0000

    sci-libs/rocFFT: add libomp to BDEPEND when using test
    
    One src file of test need omp.h header provided by sys-libs/libomp
    
    Closes: https://bugs.gentoo.org/836248
    Signed-off-by: Yiyang Wu <xgreenlandforwyy@gmail.com>
    Signed-off-by: Benda Xu <heroxbd@gentoo.org>

 sci-libs/rocFFT/rocFFT-4.3.0-r1.ebuild | 2 +-
 sci-libs/rocFFT/rocFFT-5.0.2.ebuild    | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)