Bug 835927 – Adding support for https_proxy in make.conf

• Product: Portage Development
• Status: RESOLVED FIXED

[Description Goran Muzevic 2022-03-24 15:23:04 UTC]

Hi,

currently make.conf supports setting the http_proxy,ftp_proxy and RSYNC_PROXY variables but there is no support for the https_proxy variable.
The emerge works if I manually set the https_proxy variable in console or if I put it in the /etc/profile but I believe that it would be good to also have the support directly from make.conf

host # export https_proxy="http://my_jump_host:8888"
host # emerge-webrsync    ---> works fine

Thank you for your time.

[Comment 1 John Helmert III 2022-03-24 15:27:41 UTC]

Have you tried a custom FETCHCOMMAND?

[Comment 2 Goran Muzevic 2022-03-24 20:01:15 UTC]

I've never used custom FETCHCOMMAND before so I didn't try it at the time. But yes, the custom FETCHCOMMAND also works.

[Comment 3 Larry the Git Cow 2023-08-19 14:49:47 UTC]

The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/proj/portage.git/commit/?id=2410f8d7dde2ac12de4ec040696bcbb51e09ce9f

commit 2410f8d7dde2ac12de4ec040696bcbb51e09ce9f
Author:     Sam James <[e-mail]>
AuthorDate: 2023-08-19 13:54:08 +0000
Commit:     Sam James <[e-mail]>
CommitDate: 2023-08-19 14:49:34 +0000

    save-ebuild-env.sh, special_env_vars.py: add https_proxy
    
    For parity with http_proxy.
    
    Bug: https://bugs.gentoo.org/691434
    Bug: https://bugs.gentoo.org/835927
    Bug: https://bugs.gentoo.org/911629
    Signed-off-by: Sam James <[e-mail]>

 bin/save-ebuild-env.sh                                 | 2 +-
 lib/portage/package/ebuild/_config/special_env_vars.py | 1 +
 2 files changed, 2 insertions(+), 1 deletion(-)

https://gitweb.gentoo.org/proj/portage.git/commit/?id=eb3a3878e36e32ed0f8385b7ff8e978fbbe1aff3

commit eb3a3878e36e32ed0f8385b7ff8e978fbbe1aff3
Author:     Sam James <[e-mail]>
AuthorDate: 2023-08-19 13:51:45 +0000
Commit:     Sam James <[e-mail]>
CommitDate: 2023-08-19 14:49:34 +0000

    sync: handle https_proxy too
    
    Pass down https_proxy into gemato.
    
    If http_proxy isn't set, but https_proxy is, then let's fall back to it to help
    users out. gnupg itself doesn't use https_proxy but users may have only https_proxy
    set rather than http_proxy and https_proxy.
    
    We've had cases reported where users only have https_proxy and not http_proxy set,
    so include this to help them out too.
    
    Bug: https://bugs.gentoo.org/691434
    Bug: https://bugs.gentoo.org/835927
    Bug: https://bugs.gentoo.org/911629
    Signed-off-by: Sam James <[e-mail]>

 lib/portage/sync/syncbase.py | 2 ++
 1 file changed, 2 insertions(+)

https://gitweb.gentoo.org/proj/portage.git/commit/?id=aa37e3993866f1d75e855f8c7300749fadd846af

commit aa37e3993866f1d75e855f8c7300749fadd846af
Author:     Sam James <[e-mail]>
AuthorDate: 2023-08-19 13:49:53 +0000
Commit:     Sam James <[e-mail]>
CommitDate: 2023-08-19 14:49:33 +0000

    emerge-webrsync: pass --proxy to gemato if http_proxy or https_proxy is set
    
    Make sure we pass proxy settings down into gemato.
    
    We include a fallback w/ https_proxy, but note that gnupg doesn't actually use
    https_proxy but we've had cases reported where users only have https_proxy and
    not http_proxy set, so include this to help them out too.
    
    Bug: https://bugs.gentoo.org/691434
    Bug: https://bugs.gentoo.org/835927
    Bug: https://bugs.gentoo.org/911629
    Signed-off-by: Sam James <[e-mail]>

 bin/emerge-webrsync | 7 +++++++
 1 file changed, 7 insertions(+)

https://gitweb.gentoo.org/proj/portage.git/commit/?id=f0b44fc1cc67114662b84905bc1e0cd9ce1bba28

commit f0b44fc1cc67114662b84905bc1e0cd9ce1bba28
Author:     Sam James <[e-mail]>
AuthorDate: 2023-08-19 13:49:19 +0000
Commit:     Sam James <[e-mail]>
CommitDate: 2023-08-19 14:49:33 +0000

    emerge-webrsync: handle https_proxy too
    
    If `https_proxy` is also set in make.conf, pick that up so it's passed down to
    wget.
    
    Bug: https://bugs.gentoo.org/691434
    Bug: https://bugs.gentoo.org/835927
    Bug: https://bugs.gentoo.org/911629
    Signed-off-by: Sam James <[e-mail]>

 bin/emerge-webrsync | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

[Comment 4 Larry the Git Cow 2023-08-20 07:58:35 UTC]

The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=a6a68c0255b6d3132dd555b1519a035204bffde2

commit a6a68c0255b6d3132dd555b1519a035204bffde2
Author:     Sam James <[e-mail]>
AuthorDate: 2023-08-20 07:57:47 +0000
Commit:     Sam James <[e-mail]>
CommitDate: 2023-08-20 07:58:22 +0000

    sys-apps/portage: add 3.0.51
    
    Bug: https://bugs.gentoo.org/587484
    Closes: https://bugs.gentoo.org/673624
    Closes: https://bugs.gentoo.org/691434
    Closes: https://bugs.gentoo.org/835927
    Closes: https://bugs.gentoo.org/909009
    Closes: https://bugs.gentoo.org/911335
    Closes: https://bugs.gentoo.org/911629
    Closes: https://bugs.gentoo.org/911938
    Signed-off-by: Sam James <[e-mail]>

 sys-apps/portage/Manifest              |   1 +
 sys-apps/portage/portage-3.0.51.ebuild | 234 +++++++++++++++++++++++++++++++++
 2 files changed, 235 insertions(+)