Bug 835920 – media-plugins/alsa-plugins-1.2.[2,6] build broken in install phase (for not creating alsa-lib basedir prior to ln)

• Product: Gentoo Linux
• Status: RESOLVED FIXED

[Description Eric F. GARIOUD 2022-03-24 10:27:13 UTC]

media-plugins/alsa-plugins-1.2.2  USE="-arcam_av -debug ffmpeg -jack libsamplerate -mix -oss -pulseaudio speex -usb_stream" (notice -jack) build fails in install phase whereas

media-plugins/alsa-plugins-1.2.2  USE="-arcam_av -debug ffmpeg jack libsamplerate -mix -oss -pulseaudio speex -usb_stream" (notice +jack) builds successfully.

From the reading of the failing build log at line #304 :

ln: failed to create symbolic link '/libasound_module_rate_samplerate_best.so': No such file or directory
 
I understand that the path /var/tmp/portage/media-plugins/alsa-plugins-1.2.2/image/usr/lib64/alsa-lib does not point to an existing directory.

From the reading of the successful build log from line #310, I understand that, contrarily to what happens when making install in rate, make install in jack will take care to :

/bin/mkdir -p '/var/tmp/portage/media-plugins/alsa-plugins-1.2.2/image/usr/lib64/alsa-lib'

prior to installing.
Then, because making install in rate occurs after make install in jack, make install in rate linking will happily succeed.

BTW, I did not test other combinations of useflags, so their could probably be other combinations leading to failure or success.

Reproducible: Always

[Comment 1 Eric F. GARIOUD 2022-03-24 10:28:08 UTC]

Created attachment 767720 [details]
emerge.info

[Comment 2 Eric F. GARIOUD 2022-03-24 10:29:40 UTC]

Created attachment 767721 [details]
Broken build log (USE=-jack)

[Comment 3 Eric F. GARIOUD 2022-03-24 10:30:33 UTC]

Created attachment 767722 [details]
Successful build log (USE=+jack")

[Comment 4 Eric F. GARIOUD 2022-03-24 16:19:16 UTC]

Created attachment 767734 [details, diff]
Instruct the rate plugin makefile to create the alsa-lib directory in case it does not exist already

Assuming that it won't harm anyway and that it is on the responsibility of the makefile to ensure the existence of the directory path prior to linking the plugins, this patch adds the creation of the alsa-lib directory, if it does not already exit, in the install-exec-hook section of the rate makefile.

[Comment 5 Eric F. GARIOUD 2022-03-25 11:20:47 UTC]

I realize that patching upstream's makefile might not be gentoo-devs policy friendly.
Perhaps would it be better and more useflag combination independent to create the directory once and for all as part of the ebuild.

[Comment 6 Eric F. GARIOUD 2022-04-28 05:58:36 UTC]

Also breaks for 1.2.6 (irrespective of build parallelization)
Attached patch still efficient for me.

[Comment 7 Larry the Git Cow 2022-05-09 23:21:49 UTC]

The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=dc011d3bc0c237d09ed8a45610124f458d0a2262

commit dc011d3bc0c237d09ed8a45610124f458d0a2262
Author:     Sam James <[e-mail]>
AuthorDate: 2022-05-09 23:21:12 +0000
Commit:     Sam James <[e-mail]>
CommitDate: 2022-05-09 23:21:42 +0000

    media-plugins/alsa-plugins: avoid parallel install failure
    
    Just create the dir it expects for now until upstream decide what
    they want to do w/ the hooks.
    
    Closes: https://bugs.gentoo.org/835920
    Reported-by: Eric F. GARIOUD <[e-mail]>
    Signed-off-by: Sam James <[e-mail]>

 media-plugins/alsa-plugins/alsa-plugins-1.2.6.ebuild | 8 ++++++++
 1 file changed, 8 insertions(+)