Bug 835161

Summary:	app-emulation/libvirt-8.1.0: does not build with USE=apparmor
Product:	Gentoo Linux	Reporter:	alaviss0+gentoo
Component:	Current packages	Assignee:	Matthias Maier <tamiko>
Status:	RESOLVED FIXED
Severity:	normal	CC:	miso.privoznik, virtualization
Priority:	Normal	Keywords:	PullRequest
Version:	unspecified
Hardware:	All
OS:	Linux
See Also:	https://github.com/gentoo/gentoo/pull/24568
Whiteboard:
Package list:		Runtime testing required:	---
Attachments:	Build log with USE=apparmor

Description alaviss0+gentoo 2022-03-14 21:49:45 UTC

This is caused by the faulty patch: https://github.com/gentoo/gentoo/blob/master/app-emulation/libvirt/files/libvirt-8.2.0-fix-paths-for-apparmor.patch

The patch is supposed to rename src/security/apparmor/usr.lib.libvirt.virt-aa-helper.in to src/security/apparmor/usr.libexec.libvirt.virt-aa-helper.in, but it deletes the file instead.

Reproducible: Always

Steps to Reproduce:
1. USE=apparmor emerge -1 libvirt

Comment 1 alaviss0+gentoo 2022-03-14 21:50:19 UTC

Created attachment 767074 [details]
Build log with USE=apparmor

Comment 2 Michal Privoznik 2022-03-15 04:33:54 UTC

Ooops, yes. I've messed up rebase of that patch. Sorry. Let me post a fix.

Comment 3 Larry the Git Cow gentoo-dev

2022-03-15 05:52:01 UTC

The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=4e0d1e7d8a345d6c532cd90080ccab940793ce7c

commit 4e0d1e7d8a345d6c532cd90080ccab940793ce7c
Author:     Michal Privoznik <mprivozn@redhat.com>
AuthorDate: 2022-03-15 04:25:02 +0000
Commit:     Joonas Niilola <juippis@gentoo.org>
CommitDate: 2022-03-15 05:50:37 +0000

    app-emulation/libvirt: Rebase ${PN}-8.2.0-fix-paths-for-apparmor.patch
    
    In one of my previous patches I've rebased
    libvirt-8.2.0-fix-paths-for-apparmor.patch which moves apparmor
    profiles from /usr/lib into /usr/libexec. But I forgot to 'git
    add' some files, resulting in apparmor profiles being just
    removed. Rebase the patch again, properly this time.
    
    Closes: https://bugs.gentoo.org/show_bug.cgi?id=835161
    Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
    Closes: https://github.com/gentoo/gentoo/pull/24568
    Signed-off-by: Joonas Niilola <juippis@gentoo.org>

 .../libvirt-8.2.0-fix-paths-for-apparmor.patch     | 124 +++++----------------
 1 file changed, 27 insertions(+), 97 deletions(-)