Bug 83485 – flac-1.1.1 and flac-1.1.2 shouldn't use "elibtoolize --reverse-deps" in src_unpack

• Product: Gentoo Linux
• Status: RESOLVED DUPLICATE

[Description Simone Gotti (RETIRED) 2005-02-27 10:52:54 UTC]

Looks like libtools.eclass is broken (it doesn't make a ltmain.sh version check, I'll report this in another bug) as the patch "ELT-patches/fix-relink/1.4.0" is applied to its ltmain.sh also if it's version is not 1.4.0 but 1.5.6. Plus in 1.1.2 is called libtoolize that will install the system version of libtool.

This patch instead of fixing the relink breaks it making libFLAC++ and others to link to the already installed libFLAC.so instead of the package one. This can be reproduced upgrading to flac-1.1.2 from 1.1.1 or downgrading from 1.1.2 to 1.1.1.

This can be fixed in the ebuild removing the call to "elibtoolize --reverse-deps".

I'll commit the fix if you are ok.

[Comment 1 Martin Schlemmer (RETIRED) 2005-02-27 11:32:26 UTC]

Can you test with only having 'elibtoolize' in there (without the --reverse-deps) ?

[Comment 2 Simone Gotti (RETIRED) 2005-02-27 11:53:38 UTC]

I can test it, But the problem is that the patch ELT-patches/fix-relink/1.4.0 is applied also to 1.5.6 where the relink was already fixed and this piece:

@@ -2117,7 +2141,7 @@
            -L*)
              case " $tmp_libs " in
              *" $deplib "*) ;;
-             *) tmp_libs="$tmp_libs $deplib" ;;
+             *) tmp_libs="$deplib $tmp_libs" ;;
              esac
              ;;
            *) tmp_libs="$tmp_libs $deplib" ;;

Broke it again as it reverse the -L order.

I've opened bug #83486 for this libtool.eclass problem.

[Comment 3 Martin Schlemmer (RETIRED) 2005-02-27 12:27:41 UTC]

*** This bug has been marked as a duplicate of 83486 ***