Summary: | app-laptop/asus-touchpad: asus touchpad numpad switch driver (New Package) | ||
---|---|---|---|
Product: | Gentoo Linux | Reporter: | Marco Clocchiatti <ziapannocchia> |
Component: | New packages | Assignee: | Default Assignee for New Packages <maintainer-wanted> |
Status: | CONFIRMED --- | ||
Severity: | normal | CC: | jstein |
Priority: | Normal | Keywords: | EBUILD |
Version: | unspecified | ||
Hardware: | Other | ||
OS: | Linux | ||
URL: | https://github.com/mohamed-badaoui/asus-touchpad-numpad-driver | ||
Whiteboard: | |||
Package list: | Runtime testing required: | --- | |
Attachments: |
new ebuild
new ebuild new ebuild |
Description
Marco Clocchiatti
2022-03-05 14:10:44 UTC
Created attachment 766340 [details]
new ebuild
Thank you for your contribution. I had a short look on the ebuild. Here a few ideas: * Please test the ebuild with repoman full -d -x https://wiki.gentoo.org/wiki/Repoman and pkgcheck scan --net * SRC_URI="https://github.com/cloc3/portage/raw/main/distfiles/${P}.zip" would require a dependency on unzip hence we always use tar.gz if possible * Why do HOMEPAGE and SRC_URI differ? HOMEPAGE="https://github.com/mohamed-badaoui/asus-touchpad-numpad-driver" SRC_URI="https://github.com/cloc3/portage/raw/main/distfiles/${P}.zip" (In reply to Jonas Stein from comment #2) Thank you for your reply. > > * Please test the ebuild with repoman full -d -x > https://wiki.gentoo.org/wiki/Repoman and pkgcheck scan --net > * SRC_URI="https://github.com/cloc3/portage/raw/main/distfiles/${P}.zip" > would require a dependency on unzip hence we always use tar.gz if possible > repoman seems ok: cloc3@cloc3 ~/github/portage $ repoman full -dx RepoMan scours the neighborhood... RepoMan sez: "If everyone were like you, I'd be out of business!" pkgscan gives some issues. I'll come later with a fix, but I need an explanation about your second issue: > * Why do HOMEPAGE and SRC_URI differ? > HOMEPAGE="https://github.com/mohamed-badaoui/asus-touchpad-numpad-driver" > SRC_URI="https://github.com/cloc3/portage/raw/main/distfiles/${P}.zip" I'm not a gentoo developer, but I see that often the HOMEPAGE differs from SRC_URI in gentoo ebuilds. For examples: sci-visualization/xd3d/xd3d-8.3.1-r1.ebuild HOMEPAGE="http://www.cmap.polytechnique.fr/~jouve/xd3d/" SRC_URI="mirror://gentoo/${P}.tar.gz" So, I've done something similar for my ebuild. I downloaded sources from homepage github in zip format (commit d80980af6ef776ee6acf42c193689f207caa7968) and I put them in a kind of personal "mirror" as a static copy of the original. That's also the reason because sources are not a tar.gz archive. So, what exactly is the proper way to do here? Created attachment 766431 [details] new ebuild cloc3@cloc3 ~/github/portage $ repoman full -dx RepoMan scours the neighborhood... RepoMan sez: "If everyone were like you, I'd be out of business!" cloc3@cloc3 ~/github/portage $ pkgcheck scan --net fixed for pkgcheck issues. use flags removed accordingly with https://devmanual.gentoo.org/general-concepts/use-flags/index.html#when-not-to-use-use-flags SRC_URI points to a static copy of the Homepage sources. commit: d80980af6ef776ee6acf42c193689f207caa7968 (if this is wrong, please give me your instructions). Created attachment 766583 [details]
new ebuild
fixed minor error on line 56.
sorry for the problem.
|