Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!

Bug 833903

Summary: media-gfx/imv amd64 stablereq
Product: Gentoo Linux Reporter: sunox9
Component: StabilizationAssignee: Ionen Wolkens <ionen>
Status: RESOLVED FIXED    
Severity: normal CC: jstein
Priority: Normal    
Version: unspecified   
Hardware: All   
OS: Linux   
Whiteboard:
Package list:
Runtime testing required: ---
Bug Depends on: 767799    
Bug Blocks:    

Description sunox9 2022-02-22 18:23:03 UTC
Sorry if I have submitted this to the wrong place. Just a simple stabilization request for media-gfx/imv

Reproducible: Always

Steps to Reproduce:
1.try to install media-gfx/imv
2.package is masked
3.
Comment 1 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2022-02-22 18:31:06 UTC
What architecture do you want it stabled for?
Comment 2 sunox9 2022-02-22 21:32:27 UTC
(In reply to Sam James from comment #1)
> What architecture do you want it stabled for?

x86, which I think I just added to the report. Sorry, forgot to include it the first time.
Comment 3 Ionen Wolkens gentoo-dev 2022-02-23 00:51:30 UTC
Been meaning to stable this for a while but don't particularly like that it has a known segfault path with default desktop USE by just opening a tiff image.

Unfortunately masking USE=tiff on imv wouldn't work, it'd need to be masked on freeimage and there's 1 package that depend freeimage[tiff] and some users may also be relying on it (it doesn't fail everywhere as far as I know).

Depending on freeimage[-tiff] also wouldn't be pretty being a default desktop USE, but freeimage[-tiff] and imv[tiff] is the ideal configuration for everything to work.

I've meant to look at remaking the freeimage unbundling patch before but never got to it (whole thing is a mess and it may be easy to cause more regressions -- nothing is broken if not using Gentoo's patches but then it's a security hazard).
Comment 4 Ionen Wolkens gentoo-dev 2022-02-23 00:53:41 UTC
I don't consider masking USE=freeimage great either, because that prevents use of a /lot/ of formats. Upstream also favors freeimage for a few backends over the native ones.
Comment 5 sunox9 2022-02-23 03:32:35 UTC
Sorry, I am an idiot: I actually would like the package stabilized for amd64 if it isn't too late... I'm a gentoo noob and I guess I'm used to seeing it written as x86_64. Very sorry for any inconvenience.
Comment 6 Ionen Wolkens gentoo-dev 2022-02-23 03:57:56 UTC
(In reply to sunox9 from comment #5)
> I actually would like the package stabilized for amd64
> if it isn't too late...
That's no problem, albeit no need to CC arches (amd64@) yet. This will be done when it's time to stabilize.

The package does have an issue caused by freeimage that I'd like to see resolved before considering stabilization (see bug #767799 and earlier comments). So unsure when will go forward with this.
Comment 7 Ionen Wolkens gentoo-dev 2022-02-23 04:08:02 UTC
(In reply to sunox9 from comment #5)
> I actually would like the package stabilized for amd64
> if it isn't too late...
On another note, I may add x86 too either way. Being a minimal image viewer, it may be useful on old hardware too (next version will make the larger icu dependency optional too).
Comment 8 sunox9 2022-02-23 15:17:13 UTC
(In reply to Ionen Wolkens from comment #6)
> (In reply to sunox9 from comment #5)
> > I actually would like the package stabilized for amd64
> > if it isn't too late...
> That's no problem, albeit no need to CC arches (amd64@) yet. This will be
> done when it's time to stabilize.
> 
> The package does have an issue caused by freeimage that I'd like to see
> resolved before considering stabilization (see bug #767799 and earlier
> comments). So unsure when will go forward with this.

Ok sounds great, thank you for the explanation. I had missed that related freeimage bug. I suppose I'm lucky in that I don't work with tiff images, so I am running the ~amd64 version now and seemingly without issue.

I'm slowly figuring out the bug-reporting system, and didn't realize I was CC'ing people: I just thought I was adding the amd64 arch. Good to know.
Comment 9 Larry the Git Cow gentoo-dev 2022-06-30 19:44:42 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=a56f64c9fad09f7d5089a6e7deaf92edeaf50ae0

commit a56f64c9fad09f7d5089a6e7deaf92edeaf50ae0
Author:     Ionen Wolkens <ionen@gentoo.org>
AuthorDate: 2022-06-28 11:13:40 +0000
Commit:     Ionen Wolkens <ionen@gentoo.org>
CommitDate: 2022-06-30 19:42:41 +0000

    media-gfx/imv: stabilize 4.3.1 for amd64, x86
    
    Adding x86 too, works fine and is a simple tool nice for old hardware.
    
    Closes: https://bugs.gentoo.org/833903
    Signed-off-by: Ionen Wolkens <ionen@gentoo.org>

 media-gfx/imv/imv-4.3.1.ebuild | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)