Bug 833594 – app-office/libreoffice-9999 needs dragonbox-1.1.3.tar.gz

• Product: Gentoo Linux
• Status: RESOLVED FIXED

[Description jospezial 2022-02-18 08:40:10 UTC]

https://github.com/LibreOffice/core/commit/9eb9083ff2fdaeb96399a0830a4394de4e29ef64
"Use Dragonbox to implement doubleTo*String*

This header-only library is accurate in decimal representation of
doubles; provides API that allows to create custom representation
- so it's possible to use custom decimal separators and grouping.

This allows to unify all corner cases: integers, numbers close to
DBL_MAX, up-rounding to the next decade.

Note that Dragonbox creates the shortest decimal representation
of the number, that is unambiguously convertible back to the same
number; thus it may hide trailing digits that are unneeded for
such conversion.

The functional changes are minimal, and beneficial:
1. Rounding numbers close to DBL_MAX now takes into account the
bEraseTrailingDecZeros argument, as it should, allowing to have
"1.8E+308" for rounding DBL_MAX to 2 decimals without trailing
zeroes, instead of previous "1.80E+308".
2. Incorrect rounding is fixed in some cases, e.g. 9.9999999999999929
rounded to 10 previously using rtl_math_DecimalPlaces_Max.
3. Representing the number in the shortest way may change display
of some printed numbers. E.g., 5th greatest double is represented
as "1.797693134862315E+308" instead of a bit longer, but giving
the same double on roundtrip, "1.7976931348623149E+308". This would
generally look better for some numbers similar to the famous 0.1,
where users would likely expect more "round" representation where
it's unambiguous (but we still truncate to 15 significant decimals
anyway - so there's no point in pretending to provide exact digits
for actual binary representation).

These are reflected in the unit tests affected by the change."

dragonbox is not in gentoo portage tree.

[Comment 1 jospezial 2022-02-22 17:17:22 UTC]

Please add to ADDONS_SRC in libreoffice-9999.ebuild

        # not packaged in Gentoo, https://github.com/jk-jeon/dragonbox
        "${ADDONS_URI}/dragonbox-1.1.0.tar.gz"

Or add dragonbox ebuilds to Gentoo and add --with-system-dragonbox.

https://github.com/LibreOffice/core/commit/19b0ba55ea7058b35b13f9e2ae0e8d4add374eef
"add system-dragonbox"

[Comment 2 jospezial 2022-02-22 17:33:53 UTC]

"--with-system-dragonbox" seems not to be needed when have it in Gentoo and added as dependency:

checking which cuckoo to use... internal
checking which dragonbox to use... external
checking for dragonbox/dragonbox.h... no
configure: error: dragonbox/dragonbox.h not found. install dragonbox

Until then we need "--without-system-dragonbox".

[Comment 3 jospezial 2022-02-22 17:44:23 UTC]

app-office/libreoffice/Manifest
DIST dragonbox-1.1.0.tar.gz 2837666 BLAKE2B e8f8c6668b047c3d4afa682216ddef19d0cf2b2f0e57a8ce76330daac410ba112cf4b58247942390c5b7cbf231e48a4f99e1c709424c9fed61fbfcfc9dbd3be4 SHA512 4d7cb2e0314ffda8e51600f6cbb953bf1dff9ea46d5c45a08cb0ca45ac386e8bb8b73588cd35b1a1261439a31f46447e59e2980ac6f710dec007c0c575e368e7

[Comment 4 jospezial 2022-12-03 10:07:51 UTC]

https://github.com/LibreOffice/core/commit/dd1610146528cba8642caad3bf72e27b9ca6c153
"dragonbox: upgrade to release 1.1.3"

[Comment 5 Larry the Git Cow 2022-12-26 23:19:46 UTC]

The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=5c6ce0db9735094b458da8efd6237c73e52e99c2

commit 5c6ce0db9735094b458da8efd6237c73e52e99c2
Author:     Andreas Sturmlechner <[e-mail]>
AuthorDate: 2022-12-26 13:16:16 +0000
Commit:     Andreas Sturmlechner <[e-mail]>
CommitDate: 2022-12-26 23:19:22 +0000

    app-office/libreoffice: update dependencies (more bundled SRC_URIs)
    
    Fix libreoffice-l10n blocker
    
    Thanks-to: jospezial <[e-mail]>
    Closes: https://bugs.gentoo.org/833594
    Closes: https://bugs.gentoo.org/835704
    Signed-off-by: Andreas Sturmlechner <[e-mail]>

 app-office/libreoffice/Manifest                |  1 +
 app-office/libreoffice/libreoffice-9999.ebuild | 19 +++++++++++--------
 2 files changed, 12 insertions(+), 8 deletions(-)