Bug 833322

Summary:	[guru] sys-boot/limine-2.84.1 does not respect LDFLAGS
Product:	GURU	Reporter:	Agostino Sarubbo <ago>
Component:	Package issues	Assignee:	Arsen Arsenović <arsen>
Status:	RESOLVED FIXED
Severity:	normal	CC:	arsen, guru-bugs
Priority:	Normal
Version:	unspecified
Hardware:	All
OS:	Linux
Whiteboard:
Package list:		Runtime testing required:	---
Bug Depends on:
Bug Blocks:	785607
Attachments:	build.log

Description Agostino Sarubbo gentoo-dev

2022-02-14 09:15:44 UTC

https://blogs.gentoo.org/ago/2020/07/04/gentoo-tinderbox/

Issue: sys-boot/limine-2.84.1 does not respect LDFLAGS.
Discovered on: amd64 (internal ref: guru_ci)

NOTE:
To reproduce this issue you may want to set LDFLAGS="${LDFLAGS} -Wl,--defsym=__gentoo_check_ldflags__=0". If this is not something about c/c++ context you may want to see this bug as an hint to hide the QA warning (with QA_FLAGS_IGNORED) where is not possible to respect LDFLAGS.

Comment 1 Agostino Sarubbo gentoo-dev

2022-02-14 09:15:46 UTC

Created attachment 765063 [details]
build.log

build log and emerge --info

Comment 2 Arsen Arsenović gentoo-dev

2022-02-15 12:53:08 UTC

Should be fixed by ec12547075bd3f027744356a9e096cb4daa86794.

Comment 3 James Beddek 2022-02-15 12:57:40 UTC

(In reply to Arsen Arsenovic from comment #2)
> Should be fixed by ec12547075bd3f027744356a9e096cb4daa86794.

You should take a look into using repoman/pkgdev to close related issues. From repoman --help:

  -b <BUG-NO|BUG-URL>, --bug <BUG-NO|BUG-URL>
                        Mention a Gentoo or upstream bug in the commit footer; takes either Gentoo bug number or full bug URL
  -c <PR-NO|PR-URL>, --closes <PR-NO|PR-URL>
                        Adds a Closes footer to close GitHub pull request (or compatible); takes either GitHub PR number or full PR URL

When the commit mentioning the bug is pushed to the master GURU branch, the bug will be closed automatically. I'll keep an eye on the two you've commented on and close them once they've been pushed to master.