| Summary: | media-video/ffmpegthumbnailer-2.2.0-r1 does not install file /usr/share/thumbnailers/ffmpegthumbnailer.thumbnailer with -gnome use flag | ||
|---|---|---|---|
| Product: | Gentoo Linux | Reporter: | Marko Djordjevic <homoludens79> |
| Component: | Current packages | Assignee: | Gentoo Media-video project <media-video> |
| Status: | UNCONFIRMED --- | ||
| Severity: | minor | CC: | coral.pink, da.fox.mail, jstein |
| Priority: | Normal | ||
| Version: | unspecified | ||
| Hardware: | AMD64 | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Package list: | Runtime testing required: | --- | |
| Attachments: | proposed update to the ebuild | ||
|
Description
Marko Djordjevic
2022-02-13 10:00:45 UTC
Confirming:
To get thumbnailing of videos in caja I had to create /usr/share/thumbnailers/ffmpegthumbnailer.thumbnailer.
ffmpegthumbnailer is installed as
Installed versions: 2.2.2-r1^t{tbz2}(22:46:38 01/23/23)(gtk jpeg png -gnome -test).
I USE "-gnome" as I don't want gnome trying to pull in systemd--I don't know if it still does that.
After copying ffmpegthumbnailer.thumbnailer from another distro, and restarting caja, I could see the new thumbnails.
Can confirm. The feature is behind ENABLE_THUMBNAILER flag, it only installs ffmpegthumbnailer.thumbnailer file to /usr/share/thumbnailers, and I don't think it has anything to do with gnome. Upstream defaults to disabling this, but other distros like Arch Linux [0] and Void Linux [1] package it with ENABLE_THUMBNAILER=ON by default. Also worth noting, several other packages also install thumbnailer files by default (and they don't require USE gnome or any similar flag): >$ for thumbnailer in /usr/share/thumbnailers/*; do equery -q belongs -en "$thumbnailer"; done | xargs emerge -qpv >[ebuild R ] media-libs/libheif-1.18.2-r1 USE="aom threads webp x265 -gdk-pixbuf -go -rav1e -svt-av1 -test" ABI_X86="(64) -32 (-x32)" >[ebuild R ] x11-libs/gdk-pixbuf-2.42.12 USE="gif introspection jpeg tiff -gtk-doc -test" ABI_X86="(64) -32 (-x32)" >[ebuild R ] media-video/ffmpegthumbnailer-2.2.2-r1 USE="gnome gtk jpeg png -test" >[ebuild R ] media-libs/libjxl-0.11.1 USE="gdk-pixbuf gif jpeg png -openexr -test" ABI_X86="(64) -32 (-x32)" >[ebuild R ] gnome-base/librsvg-2.58.5 USE="introspection vala -debug -gtk-doc" ABI_X86="(64) -32 (-x32)" I think it would be reasonable to remove gnome USE flag from the ebuild and turn ENABLE_THUMBNAILER on by default. --- [0]: https://gitlab.archlinux.org/archlinux/packaging/packages/ffmpegthumbnailer/-/raw/main/PKGBUILD [1]: https://raw.githubusercontent.com/void-linux/void-packages/refs/heads/master/srcpkgs/ffmpegthumbnailer/template Created attachment 919944 [details]
proposed update to the ebuild
I agree with Pink Coral's assesment. The `gnome` USE flag seems to be there only to enforce that the `gtk` USE flag is turned on (which in turn enables GIO) when someone is running the GNOME desktop.
The .thumbnailer file should always be installed, otherwise the thumbnailer won't actually be used by e.g. pcmanfm-qt.
I propose the following change.
---8<---------
--- ./gentoo/media-video/ffmpegthumbnailer/ffmpegthumbnailer-2.2.2-r1.ebuild 2024-09-12 21:13:45.000000000 +0200
+++ ./local/media-video/ffmpegthumbnailer/ffmpegthumbnailer-2.2.2-r1.ebuild 2025-02-23 13:49:17.646717293 +0100
@@ -53,7 +53,7 @@
local mycmakeargs=(
-DENABLE_GIO=$(usex gtk)
-DENABLE_TESTS=$(usex test)
- -DENABLE_THUMBNAILER=$(usex gnome)
+ -DENABLE_THUMBNAILER=yes
-DHAVE_JPEG=$(usex jpeg)
-DHAVE_PNG=$(usex png)
)
--->8---------
|