| Summary: | media-sound/grip : Display rendering hides the 'Rip' column (may be specific to high-res displays) | ||
|---|---|---|---|
| Product: | Gentoo Linux | Reporter: | Phil Stracchino (Unix Ronin) <phils> |
| Component: | Current packages | Assignee: | Gentoo Sound Team <sound> |
| Status: | UNCONFIRMED --- | ||
| Severity: | normal | CC: | jstein, phils |
| Priority: | Normal | Keywords: | PATCH |
| Version: | unspecified | ||
| Hardware: | All | ||
| OS: | Linux | ||
| URL: | https://sourceforge.net/p/grip/bugs/404/ | ||
| Whiteboard: | |||
| Package list: | Runtime testing required: | --- | |
| Attachments: |
Patch to fix the partially-hidden 'Rip' column in the Grip display
grip_screenshot_001.png |
||
Thank you for the patch. Please report it upstream (with screenshots before and after) and link the ticket here. If the patch fixes a problem, it should be merged upstream. https://sourceforge.net/p/grip/bugs/ (In reply to Jonas Stein from comment #1) > Thank you for the patch. Please report it upstream (with screenshots before > and after) and link the ticket here. > If the patch fixes a problem, it should be merged upstream. > > https://sourceforge.net/p/grip/bugs/ I just found my previous upstream ticket and posted the patch there as well. https://sourceforge.net/p/grip/bugs/404/ Created attachment 764733 [details]
grip_screenshot_001.png
Does the patch address the glitch we see in grip_screenshot_001.png?
(In reply to Jonas Stein from comment #3) > Created attachment 764733 [details] > grip_screenshot_001.png > > Does the patch address the glitch we see in grip_screenshot_001.png? No, I have never personally seen that one happen. I can say that a LOT of interface bugs were fixed in grip-4.0.0. I'll need to revert it to get a screenshot of the 'before' condition. |
Created attachment 764724 [details, diff] Patch to fix the partially-hidden 'Rip' column in the Grip display Disclaimer: THIS MAY BE DISPLAY RESOLUTION SPECIFIC. At least on a 4K display, widget widths are calculated incorrectly when the CD ripping interface is rendered, resulting in most of the Rip column being hidden. I finally got around to digging into this, and the solution is ludicrously simple. It is a one-line fix to cdplay.c. Patch will be attached in a moment. This patch works fine just dropped into /etc/portage/patches/media-sound/grip/grip-rip-width.patch.