Summary: | x11-libs/libX11-1.7.3 causes crashing of www-client/firefox | ||
---|---|---|---|
Product: | Gentoo Linux | Reporter: | Lukas Turek <8an> |
Component: | Current packages | Assignee: | Gentoo X packagers <x11> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | herrtimson, joakim.tjernlund, jstein, mozilla, trekie, usefuljunk |
Priority: | Normal | ||
Version: | unspecified | ||
Hardware: | All | ||
OS: | Linux | ||
URL: | https://gitlab.freedesktop.org/xorg/lib/libx11/-/issues/153 | ||
Whiteboard: | |||
Package list: | Runtime testing required: | --- | |
Attachments: | revert.patch |
Description
Lukas Turek
2022-02-09 12:07:18 UTC
Created attachment 764717 [details, diff]
revert.patch
Ouch. Can you try putting this revert patch in /etc/portage/patches/x11-libs/libX11/ and rebuilding libX11-1.7.3?
That should allow us to confirm whether the commit you mention is at fault.
I'm also running Firefox-91.5.0 and libX11-1.7.3, my Firefox has been on for days without issues. Not saying that ^ commit wouldn't have effect, but there might be more to this. I can confirm the patch fixed the problem, Firefox was stable for many hours. I then restarted KDE, built libX11 without the patch, restarted Firefox (so it was the only app running with unpatched libX11) and it crashed within a few minutes. Unfortunately I don't have a reliable way to trigger the crash, it often happened when I pasted something into a form field, but mostly during regular web browsing, although always when I opened a new tab - never when I was just reading or watching something. Firefox is built with USE="clang dbus eme-free hwaccel lto pgo system-av1 system-harfbuzz system-icu system-jpeg system-libevent system-libvpx system-png system-webp wayland" and uses KDE portal (kde-plasma/xdg-desktop-portal-kde). Issue filed upstream. (In reply to Lukas Turek from comment #3) > Unfortunately I don't have a reliable way to trigger the crash I found that opening new tabs and dragging them outwards to create "new" Firefox instances, is a relatively quick and reliable way to test, if the crashes persists. In my case, creating 1-6 additional instances triggered the behaviour. The revert.patch fixed the issue for me. Firefox was build with USE="lto openh264 pgo pulseaudio system-{av1, harfbuzz, icu, jpeg, libevent, libvpx, webp} hardened clang" This patch also fixes the problem, I had no crash for two work days: https://gitlab.freedesktop.org/xorg/lib/libx11/-/merge_requests/113 (In reply to Lukas Turek from comment #6) > This patch also fixes the problem, I had no crash for two work days: > https://gitlab.freedesktop.org/xorg/lib/libx11/-/merge_requests/113 Nice, lets hope it gets into Gentoo soon. The bug has been closed via the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=0d3d90c8a98363ebd13d172520a8cf11a5d0c078 commit 0d3d90c8a98363ebd13d172520a8cf11a5d0c078 Author: Matt Turner <mattst88@gentoo.org> AuthorDate: 2022-03-30 20:59:20 +0000 Commit: Matt Turner <mattst88@gentoo.org> CommitDate: 2022-03-30 21:02:19 +0000 x11-libs/libX11: Version bump to 1.7.4 Closes: https://bugs.gentoo.org/832986 Signed-off-by: Matt Turner <mattst88@gentoo.org> x11-libs/libX11/Manifest | 1 + x11-libs/libX11/libX11-1.7.4.ebuild | 40 +++++++++++++++++++++++++++++++++++++ 2 files changed, 41 insertions(+) |