Bug 832970 – sys-libs/musl: lacks pthread_getname_fp (was: sys-fs/bees-0.6.5-r1 fails to compile: task.cc:108:36: error: pthread_getname_np was not declared in this scope; did you mean pthread_setname_np?)

• Product: Gentoo Linux
• Status: RESOLVED FIXED

[Description Agostino Sarubbo 2022-02-09 07:09:48 UTC]

https://blogs.gentoo.org/ago/2020/07/04/gentoo-tinderbox/

Issue: sys-fs/bees-0.6.5-r1 fails to compile.
Discovered on: amd64 (internal ref: tinderbox_musl)

NOTE:
This machine uses MUSL libc

[Comment 1 Agostino Sarubbo 2022-02-09 07:09:51 UTC]

Created attachment 764664 [details]
build.log

build log and emerge --info

[Comment 2 Kai Krakow 2022-02-09 08:04:46 UTC]

bees does not currently support musl as long as it doesn't implement this function: pthread_getname_np

There's an open patch request for musl:
https://www.openwall.com/lists/musl/2021/05/20/8

Please re-assign to musl team.

[Comment 3 Sam James 2022-02-09 08:06:22 UTC]

(In reply to Kai Krakow from comment #2)
> bees does not currently support musl as long as it doesn't implement this
> function: pthread_getname_np
> 
> There's an open patch request for musl:
> https://www.openwall.com/lists/musl/2021/05/20/8
> 
> Please re-assign to musl team.

I'd suggest masking for now and unmasking when the bug is fixed upstream in musl.

[Comment 4 Sam James 2022-02-09 08:09:17 UTC]

(In reply to Sam James from comment #3)
> (In reply to Kai Krakow from comment #2)
> > bees does not currently support musl as long as it doesn't implement this
> > function: pthread_getname_np
> > 
> > There's an open patch request for musl:
> > https://www.openwall.com/lists/musl/2021/05/20/8
> > 
> > Please re-assign to musl team.
> 
> I'd suggest masking for now and unmasking when the bug is fixed upstream in
> musl.

Oh, it got merged, but not yet in a release: https://git.musl-libc.org/cgit/musl/commit/?id=bd3b9c4ca5e93f10f7fd891b8c07cc0c5dfd198f.

[Comment 5 Kai Krakow 2022-02-09 08:10:39 UTC]

You mean like "masking in the musl profiles"?

$PORTDIR/profiles/features/musl/package.mask

I can submit a PR. Do we keep this open then or close it with the PR?

[Comment 6 Sam James 2022-02-09 08:13:18 UTC]

(In reply to Kai Krakow from comment #5)
> You mean like "masking in the musl profiles"?
> 
> $PORTDIR/profiles/features/musl/package.mask
> 

Yep!

> I can submit a PR. Do we keep this open then or close it with the PR?

I think let's repurpose this bug for sys-libs/musl missing the function, then we'll remember to close it hopefully when we bump to the next version (as we'll check open bugs at that point). How does that sound?

(Use a Bug: tag in the mask commit, not Closes:)

[Comment 7 Kai Krakow 2022-02-09 08:16:22 UTC]

(In reply to Sam James from comment #6)
> How does that sound?

I'll try fixing this in a PR then this evening but maybe I can only do it in the weekend.

[Comment 8 Sam James 2022-04-22 02:51:59 UTC]

This is in musl 1.2.3.