| Summary: | Move page namespace select dropdown menu renders poorly over Tyrian header | ||
|---|---|---|---|
| Product: | Websites | Reporter: | Matthew Marchese <maffblaster> |
| Component: | Wiki | Assignee: | Gentoo Infrastructure <infra-bugs> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | maffblaster |
| Priority: | Normal | ||
| Version: | unspecified | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Package list: | Runtime testing required: | --- | |
| Attachments: | Picture of the overlap in action | ||
The bug has been referenced in the following commit(s): https://gitweb.gentoo.org/sites/wiki/skin-tyrian.git/commit/?id=2798b9bae5c8e95f9758e8ca3fca839344fd33db commit 2798b9bae5c8e95f9758e8ca3fca839344fd33db Author: Brian Evans <grknight@gentoo.org> AuthorDate: 2023-03-06 20:23:13 +0000 Commit: Brian Evans <grknight@gentoo.org> CommitDate: 2023-03-06 20:23:13 +0000 Attempt to reset z-index on navbar Bug: https://bugs.gentoo.org/832955 Signed-off-by: Brian Evans <grknight@gentoo.org> main.css | 4 ++++ 1 file changed, 4 insertions(+) Temporarily applying the fix to the wiki's built-in Common.css file. The Tyrian wiki skin the correct place to permanently apply the fix. https://wiki.gentoo.org/index.php?title=MediaWiki%3ACommon.css&type=revision&diff=1251062&oldid=1200949 With the help my friend David, it looks like this issue is caused by a z-index being presently set to 1000 by the Tyrian theme (tyrian.min.css), which is a higher z-index than the MediaWiki drop down on the Move page. The following commit in the wiki tyrian-skin *would* fix the issue, however it's being overridden by the class of the same name in the Tyrian theme (tyrian.min.css) provided by the CDN, which overrides the fix: https://gitweb.gentoo.org/sites/wiki/skin-tyrian.git/commit/?h=wikitest&id=2798b9bae5c8e95f9758e8ca3fca839344fd33db *However*, we could override the z-index AGAIN back to "auto" by using the Common.css functionality of MediaWiki. This is an easy option to apply and makes sense in the import order of the CSS on the wiki, but this is not the best place to fix the issue since the override must be performed independent of the Tyrian wiki skin theme itself therefore losing change visibility in code. We determined the best solution is to make the CSS selector more specific in the Tyrian wiki skin itself, which Brian attempted to do in the above commit. Change tested in the wikitest branch first, and then will be properly pulled into master: https://gitweb.gentoo.org/sites/wiki/skin-tyrian.git/commit/?id=6f94f86c865a35df7e45607109e73e212d1097cb The commit has been made in the wiki's tyrian-skin master and v1.35.5 tagged and deployed: https://gitweb.gentoo.org/sites/wiki/skin-tyrian.git/commit/?id=ef8a807e794f6a6390001d3312b055fdbbdb7100 MediaWiki:Custom.css code is no longer necessary and has been revered: https://wiki.gentoo.org/index.php?title=MediaWiki:Common.css&curid=4&diff=1271049&oldid=1251184 This bug has been successfully Resolved. It looks like Christmas has come early again this year! |
Created attachment 764644 [details] Picture of the overlap in action Image was captured on Chrome 98.0.4758.81 and FireFox 97.0 on Windows. The dropdown menu renders correctly if there's enough space in the viewport for the dropdown to forced to render in the downward direction. The issue occurs when rendering in the upward direction. Reproducible by moving the bottom of viewport upward toward the bottom of the dropdown menu. Seems like layers need fixed somehow.