Bug 831848

Summary:	kde-apps/krfb-21.12.1 improperly depends on sys-apps/xdg-desktop-portal unconditionally
Product:	Gentoo Linux	Reporter:	Luke-Jr <luke-jr+gentoobugs>
Component:	Current packages	Assignee:	Gentoo KDE team <kde>
Status:	RESOLVED UPSTREAM
Severity:	normal
Priority:	Normal
Version:	unspecified
Hardware:	All
OS:	Linux
See Also:	https://bugs.gentoo.org/show_bug.cgi?id=835928
Whiteboard:
Package list:		Runtime testing required:	---

Description Luke-Jr 2022-01-22 20:57:30 UTC

As I understand it, sys-apps/xdg-desktop-portal is only used for Wayland support, and should therefore be an optional dependency.

Comment 1 Luke-Jr 2022-01-22 21:15:11 UTC

Looking at the ebuild, it seems like there may be other deps that ought to be conditional too, but I didn't investigate them

Comment 2 Andreas Sturmlechner gentoo-dev

2022-01-23 10:52:37 UTC

wayland support is non-optional in krfb.

Comment 3 Luke-Jr 2022-01-23 20:43:56 UTC

That's not true. Deleting the xdg-desktop-portal and pipewire ebuild dependencies, krfb builds and works perfectly fine.

Comment 4 Sam James archtester

2022-01-23 21:05:00 UTC

They look not hard required but automagic (but we avoid it by depending on them unconditionally: https://invent.kde.org/network/krfb/-/blob/master/CMakeLists.txt#L82, I think.

Please submit a patch upstream to add CMake options.

Comment 5 Luke-Jr 2022-01-24 01:36:22 UTC

https://invent.kde.org/network/krfb/-/merge_requests/30/diffs

Comment 6 Andreas Sturmlechner gentoo-dev

2022-01-24 20:47:42 UTC

Thanks for taking this bug where it belongs then.