Bug 831636 – media-gfx/geeqie-1.7.1: version bump

• Product: Gentoo Linux
• Status: RESOLVED FIXED

[Description doj 2022-01-20 20:45:44 UTC]

see the attached ebuild file for version 1.7.1 of media-gfx/geeqie.
Previous versions of this ebuild forced GTK2, but it's building just fine using GTK3 and I think this is the GTK version that should be used going forward for the geeqie program.

The gentoo mirrors are currently hosting some broken tar archive of this software. In fact the file is not even a tar archive, but a HTML file. I have disabled any use of mirrors to force downloading the tar archive from github directly in the ebuild file. I don't know how to fix the gentoo mirrors. If the file on the mirrors can be fixed, then the mirror restriction can be removed from the ebuild.

Reproducible: Always

[Comment 1 doj 2022-01-20 20:46:18 UTC]

Created attachment 762900 [details]
ebuild for geeqie 1.7.1

[Comment 2 Jonas Stein 2022-01-20 23:45:06 UTC]

Thank you for your contribution. I had a short look on the ebuild. 
Here a few ideas:

* Please test the ebuild with repoman full -d -x https://wiki.gentoo.org/wiki/Repoman and pkgcheck scan --net
* We always try to use the latest EAPI, please bump to EAPI=8
* Please remove obsolete lines
* KEYWORDS need ~ for new ebuilds and after a version bump. Run ekeyword ~all YOUREBUILD
* please fix the header. (see /usr/portage/skel.ebuild and https://devmanual.gentoo.org/ebuild-writing/eapi/)
* We usually sort the KEYWORDS as ekeyword does. This makes comparison between packages easier. Simply run ekeywords on the ebuild to let it sort.
* rm -f "${D}/usr/share/doc/${PF}/COPYING"    needs |die
* A bot can look for additional mistakes, if you upload a PR via github

[Comment 3 Bernard Cafarelli 2022-01-22 10:49:18 UTC]

Thanks for the report, nice to see upstream working on a release!

In the meantime, have you tried 1.6_p20211016 ? This was to be the next stable version in tree, and ebuild has some additional flags missing in the one you uploaded (it is also a gtk3 only version). The way I did it is also to host our own tarball, to have a proper ChangeLog

I am watching the upstream mailing list:
https://www.freelists.org/archive/geeqie/01-2022

It seems they will do a new release to fix some steps - for example tarball should not have the web/ directory as it transforms a 1.7M download in a 35M one. Let's see how the discussion goes and I can then bump version in Gentoo

[Comment 4 Bernard Cafarelli 2022-01-25 22:27:43 UTC]

OK, 1.7.2 is available, has smaller tarball and a proper release on github. Bump in progress

[Comment 5 Larry the Git Cow 2022-01-25 22:29:47 UTC]

The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=6d3945dd13aad93eff90d18e3c2f81e6245223db

commit 6d3945dd13aad93eff90d18e3c2f81e6245223db
Author:     Bernard Cafarelli <[e-mail]>
AuthorDate: 2022-01-25 22:28:57 +0000
Commit:     Bernard Cafarelli <[e-mail]>
CommitDate: 2022-01-25 22:29:12 +0000

    media-gfx/geeqie: 1.7.2 bump
    
    Closes: https://bugs.gentoo.org/831636
    Package-Manager: Portage-3.0.30, Repoman-3.0.3
    Signed-off-by: Bernard Cafarelli <[e-mail]>

 media-gfx/geeqie/Manifest            |  1 +
 media-gfx/geeqie/geeqie-1.7.2.ebuild | 95 ++++++++++++++++++++++++++++++++++++
 2 files changed, 96 insertions(+)