Summary: | =app-crypt/yubioath-desktop-5.1.0-r1: unable to find QtQuick.Dialogs | ||
---|---|---|---|
Product: | Gentoo Linux | Reporter: | David Reed <david-gentoobugs> |
Component: | Current packages | Assignee: | David Seifert <soap> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | marecki |
Priority: | Normal | ||
Version: | unspecified | ||
Hardware: | All | ||
OS: | Linux | ||
URL: | https://github.com/Yubico/yubioath-desktop/issues/774 | ||
Whiteboard: | |||
Package list: | Runtime testing required: | --- |
Description
David Reed
2022-01-19 19:46:54 UTC
Oh I forgot to add, that I included the widgets USE variable for dev-qt/qtquickcontrols2, but it didn't help. Interesting. On the one hand no, yubioath-desktop does depend on qtquickcontrols2 - if it is absent the package fails src_configure. On the other, they clearly do attempt to import Qt Quick Dialogs instead of using the Dialog type from QtQuick.Controls (see https://doc.qt.io/qt-5/qtquickcontrols2-differences.html). What happens if you remove the "import QtQuick.Dialogs" line, and possibly bump the version number in the "import QtQuick.Controls" line from 2.2 to 2.3? Looks like just removing the "import QtQuick.Controls" in qml/NewCredentialView.qml fixes the error. I'm able to build and run it now without issue. Okay then, I'll notify upstream but in the meantime let's just patch this line out. Thanks for having tested this, and for the initial report of course! The bug has been closed via the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=4b8610761ef3da96cacfe7fb2874f9d8af9ea68d commit 4b8610761ef3da96cacfe7fb2874f9d8af9ea68d Author: Marek Szuba <marecki@gentoo.org> AuthorDate: 2022-01-20 21:10:29 +0000 Commit: Marek Szuba <marecki@gentoo.org> CommitDate: 2022-01-20 21:10:29 +0000 app-crypt/yubioath-desktop: do not import legacy QtQuick module yubioath-desktop looks for Qt Quick Controls 2 at configure time yet one of the QML scripts attempts to import QtQuick.Dialogs - which belongs to deprecated Qt Quick Controls 1. Patch the offending import out so that said QML script uses the class Dialog from QtQuick.Controls instead; fortunately the two classes are largely API-compatible and the script does not seem to trigger any of the (few according to documentation) incompatibilities which do exist. Closes: https://bugs.gentoo.org/831506 Signed-off-by: Marek Szuba <marecki@gentoo.org> .../files/yubioath-desktop-5.1.0-qtquickcontrols1.patch | 10 ++++++++++ ...esktop-5.1.0-r1.ebuild => yubioath-desktop-5.1.0-r2.ebuild} | 7 +++++-- 2 files changed, 15 insertions(+), 2 deletions(-) For completeness. |