Summary: | dev-db/ocp-0.3 calls ar directly | ||
---|---|---|---|
Product: | Gentoo Linux | Reporter: | Agostino Sarubbo <ago> |
Component: | Current packages | Assignee: | Max Satula <maksym.satula> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | fedeliallalinea, proxy-maint, sam |
Priority: | Normal | Keywords: | PullRequest |
Version: | unspecified | ||
Hardware: | All | ||
OS: | Linux | ||
See Also: | https://github.com/gentoo/gentoo/pull/23879 | ||
Whiteboard: | |||
Package list: | Runtime testing required: | --- | |
Bug Depends on: | |||
Bug Blocks: | 243502 | ||
Attachments: |
build.log
ocp-ar.patch |
Description
Agostino Sarubbo
2022-01-16 10:24:24 UTC
CC'ing also the author of the commit (516ae59120b0656fb3c47e5a4631bef0cc7eef00) Created attachment 762287 [details]
build.log
build log and emerge --info
Error(s) that match a know pattern: make[2]: ar: No such file or directory Created attachment 762329 [details, diff]
ocp-ar.patch
The problem is not related to commit 516ae59120b0656fb3c47e5a4631bef0cc7eef00, but the patch seems to solve the problem.
(In reply to Marco Genasci from comment #4) > Created attachment 762329 [details, diff] [details, diff] > ocp-ar.patch > > The problem is not related to commit > 516ae59120b0656fb3c47e5a4631bef0cc7eef00, but the patch seems to solve the > problem. Makefile.in is generated by automake based on Makefile.am Do you know by the chance on how to tell automake to generate a good Makefile.in without having to patch it manually every time it is regenerated? Does not it sound as a bug in GNU automake? (In reply to Max Satula from comment #5) > Do you know by the chance on how to tell automake to generate a good > Makefile.in without having to patch it manually every time it is regenerated? No, but another way is to inherit toolchain-funcs eclass and add src_compile function: src_compile() { emake AR="$(tc-getAR)" } like commit 873d874069600e85391fd46206665c70751f0beb (In reply to Marco Genasci from comment #7) > (In reply to Max Satula from comment #5) > > Do you know by the chance on how to tell automake to generate a good > > Makefile.in without having to patch it manually every time it is regenerated? > > No, but another way is to inherit toolchain-funcs eclass and add src_compile > function: > > src_compile() { > emake AR="$(tc-getAR)" > } > > like commit 873d874069600e85391fd46206665c70751f0beb I personally like this one better. Did this approach applied to dev-db/ocp work for you? If so, I'll submit a PR (unless you do a favor of taking care of it). Thank you! (In reply to Max Satula from comment #8) > I personally like this one better. Did this approach applied to dev-db/ocp > work for you? If so, I'll submit a PR (unless you do a favor of taking care > of it). Thank you! Yes it seems to work. The bug has been closed via the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=7f7653c57cf5f7d60c9d5c97c7d36887e3600f25 commit 7f7653c57cf5f7d60c9d5c97c7d36887e3600f25 Author: Marco Genasci <fedeliallalinea@gmail.com> AuthorDate: 2022-01-20 06:42:16 +0000 Commit: Sam James <sam@gentoo.org> CommitDate: 2022-01-20 12:31:13 +0000 dev-db/ocp: fix AR direct call Closes: https://bugs.gentoo.org/831291 Package-Manager: Portage-3.0.28, Repoman-3.0.3 Signed-off-by: Marco Genasci <fedeliallalinea@gmail.com> Closes: https://github.com/gentoo/gentoo/pull/23879 Signed-off-by: Sam James <sam@gentoo.org> dev-db/ocp/ocp-0.3.ebuild | 11 ++++++++--- dev-db/ocp/ocp-9999.ebuild | 11 ++++++++--- 2 files changed, 16 insertions(+), 6 deletions(-) The bug has been referenced in the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=ffbe6ac5b5d4ccc29993e3d7ae68625afbf871df commit ffbe6ac5b5d4ccc29993e3d7ae68625afbf871df Author: Sam James <sam@gentoo.org> AuthorDate: 2022-01-20 15:21:41 +0000 Commit: Sam James <sam@gentoo.org> CommitDate: 2022-01-20 15:21:41 +0000 dev-db/ocp: move common inherit out Bug: https://bugs.gentoo.org/831291 Signed-off-by: Sam James <sam@gentoo.org> dev-db/ocp/ocp-0.3.ebuild | 5 +++-- dev-db/ocp/ocp-9999.ebuild | 5 +++-- 2 files changed, 6 insertions(+), 4 deletions(-) |