Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!

Bug 830930

Summary: games-emulation/dosbox-staging-0.78.0 - ../dosbox-staging-0.78.0/src/libs/loguru/loguru.cpp:103:18: fatal error: execinfo.h: No such file or directory (on musl)
Product: Gentoo Linux Reporter: ernsteiswuerfel <erhard_f>
Component: Current packagesAssignee: Bernard Cafarelli <voyageur>
Status: RESOLVED FIXED    
Severity: normal    
Priority: Normal    
Version: unspecified   
Hardware: All   
OS: Linux   
Whiteboard:
Package list:
Runtime testing required: ---
Bug Depends on:    
Bug Blocks: 430702    
Attachments: build.log
emerge --info
Patch to disable backtrace when not on glibc

Description ernsteiswuerfel archtester 2022-01-10 16:22:26 UTC
Created attachment 761787 [details]
build.log

[...]
[198/203] x86_64-gentoo-linux-musl-gcc -Isrc/libs/decoders/libdecoders.a.p -Isrc/libs/decoders -I../dosbox-staging-0.78.0/src/libs/decoders -I../dosbox-staging-0.78.0/include -I. -I../dosbox-staging-0.78.0 -Isrc/libs/loguru -I../dosbox-staging-0.78.0/src/libs/loguru -I/usr/include/SDL2 -I/usr/include/opus -fdiagnostics-color=always -DNDEBUG -D_FILE_OFFSET_BITS=64 -Wall -Winvalid-pch -Wextra -Wpedantic -Wmaybe-uninitialized -shared-libgcc -fPIC -O2 -march=x86-64 -msse3 -mtune=k8 -pipe -D_REENTRANT -MD -MQ src/libs/decoders/libdecoders.a.p/SDL_sound.c.o -MF src/libs/decoders/libdecoders.a.p/SDL_sound.c.o.d -o src/libs/decoders/libdecoders.a.p/SDL_sound.c.o -c ../dosbox-staging-0.78.0/src/libs/decoders/SDL_sound.c
[199/203] x86_64-gentoo-linux-musl-g++ -Isrc/libs/loguru/libloguru.a.p -Isrc/libs/loguru -I../dosbox-staging-0.78.0/src/libs/loguru -fdiagnostics-color=always -DNDEBUG -D_FILE_OFFSET_BITS=64 -Wall -Winvalid-pch -Wnon-virtual-dtor -Wextra -Wpedantic -std=c++17 -Wmaybe-uninitialized -Weffc++ -Wextra-semi -shared-libgcc -fPIC -O2 -march=x86-64 -msse3 -mtune=k8 -pipe -pthread -MD -MQ src/libs/loguru/libloguru.a.p/loguru.cpp.o -MF src/libs/loguru/libloguru.a.p/loguru.cpp.o.d -o src/libs/loguru/libloguru.a.p/loguru.cpp.o -c ../dosbox-staging-0.78.0/src/libs/loguru/loguru.cpp
FAILED: src/libs/loguru/libloguru.a.p/loguru.cpp.o 
x86_64-gentoo-linux-musl-g++ -Isrc/libs/loguru/libloguru.a.p -Isrc/libs/loguru -I../dosbox-staging-0.78.0/src/libs/loguru -fdiagnostics-color=always -DNDEBUG -D_FILE_OFFSET_BITS=64 -Wall -Winvalid-pch -Wnon-virtual-dtor -Wextra -Wpedantic -std=c++17 -Wmaybe-uninitialized -Weffc++ -Wextra-semi -shared-libgcc -fPIC -O2 -march=x86-64 -msse3 -mtune=k8 -pipe -pthread -MD -MQ src/libs/loguru/libloguru.a.p/loguru.cpp.o -MF src/libs/loguru/libloguru.a.p/loguru.cpp.o.d -o src/libs/loguru/libloguru.a.p/loguru.cpp.o -c ../dosbox-staging-0.78.0/src/libs/loguru/loguru.cpp
../dosbox-staging-0.78.0/src/libs/loguru/loguru.cpp:103:18: fatal error: execinfo.h: No such file or directory
  103 |         #include <execinfo.h>  // for backtrace
      |                  ^~~~~~~~~~~~
compilation terminated.
ninja: build stopped: subcommand failed.
 * ERROR: games-emulation/dosbox-staging-0.78.0::gentoo failed (compile phase):
Comment 1 ernsteiswuerfel archtester 2022-01-10 16:22:54 UTC
Created attachment 761788 [details]
emerge --info
Comment 2 Bernard Cafarelli gentoo-dev 2022-01-12 20:34:56 UTC
Did dosbox-staging work fine before the loguru inclusion? If yes, we can push upstream a change similar to https://github.com/emilk/loguru/issues/69 suggestion
Comment 3 Bernard Cafarelli gentoo-dev 2022-01-12 20:35:29 UTC
Created attachment 761988 [details, diff]
Patch to disable backtrace when not on glibc
Comment 4 ernsteiswuerfel archtester 2022-01-13 22:39:18 UTC
(In reply to Bernard Cafarelli from comment #2)
> Did dosbox-staging work fine before the loguru inclusion?
0.77.1 built and worked fine. Starting with 0.78.0 the build fails on musl. And with your patch it builds again. Thanks!
Comment 5 Bernard Cafarelli gentoo-dev 2022-01-15 09:51:59 UTC
OK, I pushed a PR in loguru itself and filled a bug in dosbox-staging to see how to fix it upstream, in the meantime I will add it to 0.78.1 ebuild

https://github.com/dosbox-staging/dosbox-staging/issues/1528
https://github.com/emilk/loguru/pull/206
Comment 6 Larry the Git Cow gentoo-dev 2022-01-15 10:01:30 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=0784ac677157c9940fe45091321c9939a9daa559

commit 0784ac677157c9940fe45091321c9939a9daa559
Author:     Bernard Cafarelli <voyageur@gentoo.org>
AuthorDate: 2022-01-15 09:59:46 +0000
Commit:     Bernard Cafarelli <voyageur@gentoo.org>
CommitDate: 2022-01-15 10:01:24 +0000

    games-emulation/dosbox-staging: fix compilation with musl
    
    Closes: https://bugs.gentoo.org/830930
    Package-Manager: Portage-3.0.30, Repoman-3.0.3
    Signed-off-by: Bernard Cafarelli <voyageur@gentoo.org>

 .../dosbox-staging/dosbox-staging-0.78.1.ebuild          |  2 ++
 .../files/dosbox-staging-0.78.1-musl.patch               | 16 ++++++++++++++++
 2 files changed, 18 insertions(+)
Comment 7 Bernard Cafarelli gentoo-dev 2022-01-16 11:27:29 UTC
@ernsteiswuerfel that was quickly merged upstream, nice! If you have time, can you check if their master branch runs fine with musl?
Comment 8 ernsteiswuerfel archtester 2022-01-16 12:16:32 UTC
Just built upstream master with default config on musl amd64. Works well.
Comment 9 Bernard Cafarelli gentoo-dev 2022-01-16 22:21:07 UTC
Thanks for checking, that was one fast to get fixed :)