| Summary: | net-irc/quassel-0.14.0 mangles CXXFLAGS containing duplicate words | ||
|---|---|---|---|
| Product: | Gentoo Linux | Reporter: | Michał Górny <mgorny> |
| Component: | Current packages | Assignee: | Sam James <sam> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | floppym |
| Priority: | Normal | ||
| Version: | unspecified | ||
| Hardware: | All | ||
| OS: | Linux | ||
| See Also: | https://github.com/quassel/quassel/pull/595 | ||
| Whiteboard: | |||
| Package list: | Runtime testing required: | --- | |
| Attachments: |
/var/log/portage/net-irc:quassel-0.14.0:20220107-160217.log
emerge --info |
||
|
Description
Michał Górny
2022-01-07 16:04:11 UTC
Created attachment 761515 [details]
emerge --info
CXXFLAGS contain "--param l1-cache-size=32 --param l1-cache-line-size=64". The second "--param" is getting dropped. The problem is in this "process_cmake_cxx_flags()" macro. https://github.com/quassel/quassel/blob/0.14.0/cmake/QuasselMacros.cmake#L414 It splits CXXFLAGS into a list of arguments using separate_arguments(). It then calls add_compile_options() on this list. The add_compile_options() function "de-duplicates" the options. https://cmake.org/cmake/help/latest/command/add_compile_options.html#option-de-duplication Opened a PR upstream. this form should work too btw: --param=l1-cache-line-size=64 I always found this form less problematic for parsing. cmake of course should be fixed, just adding a data point (In reply to Georgy Yakovlev from comment #4) > this form should work too btw: > > --param=l1-cache-line-size=64 > > I always found this form less problematic for parsing. > > cmake of course should be fixed, just adding a data point Who will catch the bugs then? ;-) The bug has been closed via the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=4da043aa794888f08ab2ebfda77a95182f96ed38 commit 4da043aa794888f08ab2ebfda77a95182f96ed38 Author: Mike Gilbert <floppym@gentoo.org> AuthorDate: 2022-01-14 18:31:01 +0000 Commit: Mike Gilbert <floppym@gentoo.org> CommitDate: 2022-01-14 18:31:01 +0000 net-irc/quassel: fix CXXFLAGS de-duplication Closes: https://bugs.gentoo.org/830738 Signed-off-by: Mike Gilbert <floppym@gentoo.org> .../quassel/files/quassel-0.14.0-cxxflags.patch | 32 ++++++++++++++++++++++ net-irc/quassel/quassel-0.14.0.ebuild | 4 +++ 2 files changed, 36 insertions(+) |