Bug 830469

Summary:	games-emulation/nestopia-1.50 fails to compile: NstInpPowerGlove.cpp:79:6: error: non-constant-expression cannot be narrowed from type Nes::uint (aka unsigned int) to Nes::byte (aka unsigned char) in initializer list [-Wc++11-narrowing]
Product:	Gentoo Linux	Reporter:	Agostino Sarubbo <ago>
Component:	Current packages	Assignee:	Gentoo Games <games>
Status:	RESOLVED FIXED
Severity:	normal
Priority:	Normal
Version:	unspecified
Hardware:	All
OS:	Linux
Whiteboard:
Package list:		Runtime testing required:	---
Attachments:	build.log

Description Agostino Sarubbo gentoo-dev

2022-01-02 21:16:02 UTC

https://blogs.gentoo.org/ago/2020/07/04/gentoo-tinderbox/

Issue: games-emulation/nestopia-1.50 fails to compile.
Discovered on: amd64 (internal ref: tinderbox)

NOTE:
This machine uses CLANG as a compiler and LLD as a linker

Comment 1 Agostino Sarubbo gentoo-dev

2022-01-02 21:16:04 UTC

Created attachment 761110 [details]
build.log

build log and emerge --info

Comment 2 Larry the Git Cow gentoo-dev

2022-02-09 19:16:00 UTC

The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=7756de4318427c9b5810f62730b1bef9f87ea9e4

commit 7756de4318427c9b5810f62730b1bef9f87ea9e4
Author:     David Seifert <soap@gentoo.org>
AuthorDate: 2022-02-09 19:15:54 +0000
Commit:     David Seifert <soap@gentoo.org>
CommitDate: 2022-02-09 19:15:54 +0000

    games-emulation/nestopia: silence -Wc++11-narrowing on clang
    
    Closes: https://bugs.gentoo.org/830469
    Signed-off-by: David Seifert <soap@gentoo.org>

 games-emulation/nestopia/nestopia-1.51.1.ebuild | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

Comment 3 Larry the Git Cow gentoo-dev

2025-03-24 02:59:52 UTC

The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=3eaca02b4f210fa06b6ffe784cf8dec4a9712546

commit 3eaca02b4f210fa06b6ffe784cf8dec4a9712546
Author:     Ionen Wolkens <ionen@gentoo.org>
AuthorDate: 2025-03-24 02:40:44 +0000
Commit:     Ionen Wolkens <ionen@gentoo.org>
CommitDate: 2025-03-24 02:59:31 +0000

    games-emulation/nestopia: add 1.53.1
    
    Also drop the -Wno-narrowing workaround, 1.53.0 was still failing
    without that but seems 1.53.1 fixed this now.
    
    Bug: https://bugs.gentoo.org/830469
    Signed-off-by: Ionen Wolkens <ionen@gentoo.org>

 games-emulation/nestopia/Manifest               |  1 +
 games-emulation/nestopia/nestopia-1.53.1.ebuild | 42 +++++++++++++++++++++++++
 2 files changed, 43 insertions(+)