Bug 830429 – media-gfx/gimp-9999 sed fails because of migration from gtk-doc to gi-docgen

• Product: Gentoo Linux
• Status: RESOLVED FIXED

[Description jospezial 2022-01-02 06:03:04 UTC]

https://gitlab.gnome.org/GNOME/gimp/-/commit/92e80d12e84df92b9ee4b2ece0d4e485bde67158
"docs: Migrate from gtk-doc to gi-docgen"

>>> Source unpacked in /var/tmp/portage/media-gfx/gimp-9999/work
>>> Preparing source in /var/tmp/portage/media-gfx/gimp-9999/work/gimp-9999 ...
sed: can't read /var/tmp/portage/media-gfx/gimp-9999/work/gimp-9999/devel-docs/libgimp/Makefile.am: No such file or directory
sed: can't read /var/tmp/portage/media-gfx/gimp-9999/work/gimp-9999/devel-docs/libgimpbase/Makefile.am: No such file or directory
sed: can't read /var/tmp/portage/media-gfx/gimp-9999/work/gimp-9999/devel-docs/libgimpcolor/Makefile.am: No such file or directory
sed: can't read /var/tmp/portage/media-gfx/gimp-9999/work/gimp-9999/devel-docs/libgimpconfig/Makefile.am: No such file or directory
sed: can't read /var/tmp/portage/media-gfx/gimp-9999/work/gimp-9999/devel-docs/libgimpmath/Makefile.am: No such file or directory
sed: can't read /var/tmp/portage/media-gfx/gimp-9999/work/gimp-9999/devel-docs/libgimpmodule/Makefile.am: No such file or directory
sed: can't read /var/tmp/portage/media-gfx/gimp-9999/work/gimp-9999/devel-docs/libgimpthumb/Makefile.am: No such file or directory
sed: can't read /var/tmp/portage/media-gfx/gimp-9999/work/gimp-9999/devel-docs/libgimpwidgets/Makefile.am: No such file or directory
 * ERROR: media-gfx/gimp-9999::gentoo failed (prepare phase):
 *   (no error message)
 * 
 * Call stack:
 *     ebuild.sh, line 127:  Called src_prepare
 *   environment, line 4382:  Called die
 * The specific snippet of code:
 *           sed -i -e "/CLEANFILES/s/^/#/g" "${S}"/devel-docs/{libgimp,libgimpbase,libgimpcolor,libgimpconfig,libgimpmath,libgimpmodule,libgimpthumb,libgimpwidgets}/Makefile.am || die;
 *

[Comment 1 Sam James 2022-01-02 06:18:27 UTC]

Yeah, mentioned in https://github.com/gentoo/gentoo/pull/23297 too.

[Comment 2 Sergey Torokhov 2022-01-04 14:17:42 UTC]

I can add quick fix with updating deps to gi-docgen instead of gtk-doc, gtk-doc-am and for configuration phase.

The current problem is that after install phase I don't see any devel-docs in sandbox image directory after build with USE="doc". Maybe it depends on something else (devel-docs install looks fine) or devel-docs will be generated for python, vala etc plugin API.

[Comment 3 Daniel Novomeský 2022-01-09 12:51:09 UTC]

Created attachment 761705 [details]
gimp-9999.ebuild

I attached gimp-9999.ebuild which works for me.

Just add the easy fix (replacing gtk-doc + gtk-doc-am) with dev-util/gi-docgen, bump gegl dependency.

Don't worry about the documentation now. Using gi-docgen in GIMP is a fresh feature, perhaps there will be more work on upstream side first.

[Comment 4 Sergey Torokhov 2022-01-09 13:59:16 UTC]

I tested own ebuild with addidionally enabled g-ir-doc but it's build failed due to parsing error. So I will left this option disabled. 

Also I fixed additional dependency issue (easy) for 2.99.x and 9999. But I certainly must at least fix this issue by pr. Sorry for long delay :(

[Comment 5 Larry the Git Cow 2022-01-18 12:36:33 UTC]

The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=314615bdea98822feee429e7f7ad58048c509b79

commit 314615bdea98822feee429e7f7ad58048c509b79
Author:     Sergey Torokhov <[e-mail]>
AuthorDate: 2022-01-09 15:35:13 +0000
Commit:     Sam James <[e-mail]>
CommitDate: 2022-01-18 12:34:32 +0000

    media-gfx/gimp: 9999 fix USE=doc build due to new dependencies
    
    Closes: https://bugs.gentoo.org/830429
    
    Signed-off-by: Sergey Torokhov <[e-mail]>
    Signed-off-by: Sam James <[e-mail]>

 media-gfx/gimp/gimp-9999.ebuild | 19 ++++---------------
 1 file changed, 4 insertions(+), 15 deletions(-)