| Summary: | sci-libs/flann-1.9.1-r4: Fails in cmake, CMake Error at src/matlab/CMakeLists.txt:19 (get_property): | ||
|---|---|---|---|
| Product: | Gentoo Linux | Reporter: | Erik Zeek <zeekec> |
| Component: | Current packages | Assignee: | Gentoo Science Related Packages <sci> |
| Status: | CONFIRMED --- | ||
| Severity: | normal | CC: | fatzer2, jstein, kripton, lssndrbarbieri, sam |
| Priority: | Normal | Keywords: | PullRequest |
| Version: | unspecified | ||
| Hardware: | All | ||
| OS: | Linux | ||
| See Also: | https://github.com/gentoo/gentoo/pull/24221 | ||
| Whiteboard: | |||
| Package list: | Runtime testing required: | --- | |
| Attachments: |
emerge --info '=sci-libs/flann-1.9.1-r4::gentoo'
flann-1.9.1-fix-matlab-cmake.patch A simple patch |
||
|
Description
Erik Zeek
2022-01-02 01:00:23 UTC
Out of interest, do you need USE=octave for this package? It's really on life support and I'm considering masking that USE flag rather than applying yet another heap of patches. Possible that something from https://github.com/flann-lib/flann/pull/343 could help though. (In reply to Sam James from comment #1) > Out of interest, do you need USE=octave for this package? Nope. > It's really on life support and I'm considering masking that USE flag rather > than applying yet another heap of patches. That's fine by me. > Possible that something from > https://github.com/flann-lib/flann/pull/343 could help though. (In reply to Sam James from comment #1) > Out of interest, do you need USE=octave for this package? > > It's really on life support and I'm considering masking that USE flag rather > than applying yet another heap of patches. Possible that something from > https://github.com/flann-lib/flann/pull/343 could help though. Could you reconsider? it's just a simple cmake issue; a proposed pathch is following. Created attachment 765220 [details, diff]
flann-1.9.1-fix-matlab-cmake.patch
(In reply to Fat-Zer from comment #3) > (In reply to Sam James from comment #1) > > Out of interest, do you need USE=octave for this package? > > > > It's really on life support and I'm considering masking that USE flag rather > > than applying yet another heap of patches. Possible that something from > > https://github.com/flann-lib/flann/pull/343 could help though. > > Could you reconsider? it's just a simple cmake issue; a proposed pathch is > following. There's a huge heap of patches and I'd rather not add another one, but I guess fine if it's useful to you. Please provide a git am-able patch with GCO sign off I can apply to gentoo.git directly. The patch actually clobbers with the sed'ing inside the ebuild (patches are applied after `sed`). Would you like me to incorporate it into the patch?
-------------------
sed command from the ebuild for reference:
-------------------
sed -i \
-e 's/--mex//' \
-e 's/\.mex/\.oct/' \
-e '/FILES/s/${MEX_FILE}//' \
-e 's:share/flann/octave:share/octave/site/m:' \
-e "/CUSTOM_TARGET/a\INSTALL(FILES \${MEX_FILE} DESTINATION libexec/octave/site/oct/${CHOST})" \
src/matlab/CMakeLists.txt || die
Created attachment 765275 [details, diff]
A simple patch
The bug has been referenced in the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=7e0b5dc2646707633bf113215c122a8f045476b1 commit 7e0b5dc2646707633bf113215c122a8f045476b1 Author: Alexander Golubev <fatzer2@gmail.com> AuthorDate: 2022-02-16 22:05:23 +0000 Commit: Sam James <sam@gentoo.org> CommitDate: 2022-02-18 03:05:14 +0000 sci-libs/flann: revbump to fix MATLAB support + Avoid sed'ing cmake files + Install octave files to a more opropriate locationa Bug: https://bugs.gentoo.org/830424 Signed-off-by: Alexander Golubev <fatzer2@gmail.com> Signed-off-by: Sam James <sam@gentoo.org> ...uild-oct-rather-than-mex-files-for-octave.patch | 81 ++++++++++++++++++++ sci-libs/flann/flann-1.9.1-r5.ebuild | 88 ++++++++++++++++++++++ 2 files changed, 169 insertions(+) |
